You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by cu...@apache.org on 2019/05/24 13:50:20 UTC
[whimsy] branch master updated: Optimization: only pass args needed
by individual controls
This is an automated email from the ASF dual-hosted git repository.
curcuru pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new d591d63 Optimization: only pass args needed by individual controls
d591d63 is described below
commit d591d63f6d6f6381b146a4f9f04c225ec4e981c2
Author: Shane Curcuru <as...@shanecurcuru.org>
AuthorDate: Fri May 24 09:50:11 2019 -0400
Optimization: only pass args needed by individual controls
---
lib/whimsy/asf/forms.rb | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/whimsy/asf/forms.rb b/lib/whimsy/asf/forms.rb
index 2176038..f4e4482 100644
--- a/lib/whimsy/asf/forms.rb
+++ b/lib/whimsy/asf/forms.rb
@@ -38,7 +38,7 @@ class Wunderbar::HtmlMarkup
end
# Display a single input control within a form; or if rows, then a textarea
- # @param name required string ID of control's label
+ # @param name required string ID of control's label/id
def _whimsy_forms_input(**args)
return unless args[:name]
args[:label] ||= 'Enter string'
@@ -48,17 +48,17 @@ class Wunderbar::HtmlMarkup
_whimsy_control_wrapper(args) do
args[:class] = 'form-control'
if args[:rows]
- _textarea! args do
+ _textarea! type: args[:type], name: args[:name], id: args[:id], value: args[:value], class: args[:class], aria_describedby: args[:aria_describedby], rows: args[:rows] do
_! args[:value]
end
else
- _input args
+ _input type: args[:type], name: args[:name], id: args[:id], value: args[:value], class: args[:class], aria_describedby: args[:aria_describedby]
end
end
end
# Display an optionlist control within a form
- # @param name required string ID of control's label
+ # @param name required string ID of control's label/id
# @param options required ['value'] or {"value" => 'Label for value'} of all selectable values
# @param values required 'value' or ['value'] or {"value" => 'Label for value'} of all selected values
# @param placeholder Currently displayed text if passed (not selectable)
@@ -72,7 +72,7 @@ class Wunderbar::HtmlMarkup
if args[:multiple]
args[:multiple] = 'true'
end
- _select.form_control args do
+ _select.form_control type: args[:type], name: args[:name], id: args[:id], value: args[:value], aria_describedby: args[:aria_describedby], multiple: args[:multiple] do
if ''.eql?(args[:placeholder])
_option '', value: '', selected: 'selected'
else