You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jw...@apache.org on 2002/11/23 22:18:17 UTC

cvs commit: httpd-2.0/modules/cache mod_file_cache.c

jwoolley    2002/11/23 13:18:17

  Modified:    modules/cache mod_file_cache.c
  Log:
  update a comment
  
  Revision  Changes    Path
  1.74      +6 -8      httpd-2.0/modules/cache/mod_file_cache.c
  
  Index: mod_file_cache.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/cache/mod_file_cache.c,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -d -u -r1.73 -r1.74
  --- mod_file_cache.c	9 Jun 2002 03:44:03 -0000	1.73
  +++ mod_file_cache.c	23 Nov 2002 21:18:16 -0000	1.74
  @@ -249,14 +249,12 @@
               return;
           }
           apr_file_close(fd);
  -        /* We want to cache an apr_mmap_t that's marked as "non-owner"
  -         * to pass to each request so that mmap_setaside()'s call to
  -         * apr_mmap_dup() will never try to move the apr_mmap_t to a
  -         * different pool.  This apr_mmap_t is already going to live
  -         * longer than any request, but mmap_setaside() has no way to
  -         * know that because it's allocated out of cmd->pool,
  -         * which is disjoint from r->pool.
  -         */
  +        /* We want to cache a duplicate apr_mmap_t to pass to each
  +         * request so that nothing in the request will ever think that
  +         * it's allowed to delete the mmap, since the "refcount" will
  +         * never reach zero. */
  +        /* XXX: the transfer_ownership flag on this call
  +         * will go away soon.. it's ignored right now. */
           apr_mmap_dup(&new_file->mm, mm, cmd->pool, 0);
           new_file->is_mmapped = TRUE;
       }