You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/04/03 23:13:30 UTC
[jclouds-labs-openstack] Backport checkstyle fixes (#92)
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack backport-checkstyle-fixes
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/92
-- Commit Summary --
* Fixes checkstyle violations in neutron.
* Fixes more checkstyle violations.
-- File Changes --
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/ExternalGatewayInfo.java (2)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Router.java (2)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/RouterInterface.java (2)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateRouterOptions.java (2)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/UpdateRouterOptions.java (2)
M openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/ObjectApi.java (1)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/CreateScalingPolicy.java (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/92.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/92.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by Zack Shoylev <no...@github.com>.
Closed #92.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #218](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/218/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39515207
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #219](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/219/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39518715
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #213](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/213/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39506567
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1031](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1031/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39524401
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by Zack Shoylev <no...@github.com>.
merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39527791
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #220](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/220/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39524494
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1030](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1030/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39518754
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by Andrew Phillips <no...@github.com>.
+1 - thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39645821
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by Zack Shoylev <no...@github.com>.
https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/220/violations/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39527338
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by Zack Shoylev <no...@github.com>.
There were two separate PRs to fix checkstyle problems in master.
The second also fixed code that is not in 1.7.x so it had to be resolved.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39505835
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by Zack Shoylev <no...@github.com>.
Had to rebase and add some missing fixes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39518263
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1019](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1019/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39507416
Re: [jclouds-labs-openstack] Backport checkstyle fixes (#92)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1027](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1027/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/92#issuecomment-39515199