You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/06/17 11:46:59 UTC
[Impala-ASF-CR] IMPALA-11367: There should be LINE DELIM above '# Partition Transform Information'
lipenglin@sensorsdata.cn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18634
Change subject: IMPALA-11367: There should be LINE_DELIM above '# Partition Transform Information'
......................................................................
IMPALA-11367: There should be LINE_DELIM above '# Partition Transform Information'
Fix 'LINE_DELIM' is missing on '# Partition Transform Information' when
DESCRIBE FORMATTED for Iceberg tables.
Testing:
- Existing tests
Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
---
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/18634/1
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
[Impala-ASF-CR] IMPALA-11367: There should be LINE DELIM above '# Partition Transform Information'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: There should be LINE_DELIM above '# Partition Transform Information'
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10796/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 12:05:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18634/2/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java:
http://gerrit.cloudera.org:8080/#/c/18634/2/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@175
PS2, Line 175: private static final String partitionTransformSchema = "col_name,transform_type#string:string";
line too long (97 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 14:46:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables:
- 'LINE_DELIM' is missing on '# Partition Transform Information'
- The partition transform columns header should be
'col_name,transform_type,NULL'
Testing:
- Existing tests
Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Reviewed-on: http://gerrit.cloudera.org:8080/18634
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 23 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8243/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 15:15:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8248/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 09:24:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 14:06:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10798/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 15:09:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18634/1/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java:
http://gerrit.cloudera.org:8080/#/c/18634/1/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@112
PS1, Line 112: formatPartitionTransformColumnsHeader(info);
> Also in the columns header we should see
Done
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 16:04:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables:
- 'LINE_DELIM' is missing on '# Partition Transform Information'
- The partition transform columns header should be
'col_name,transform_type,NULL'
Testing:
- Existing tests
Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
---
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/18634/2
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10797/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 15:06:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables:
- 'LINE_DELIM' is missing on '# Partition Transform Information'
- The partition transform columns header should be
'col_name,transform_type,NULL'
Testing:
- Existing tests
Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
---
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/18634/4
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10799/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 15:45:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8243/
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 15:15:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 4: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 09:23:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 09:24:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
......................................................................
IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables
Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables:
- 'LINE_DELIM' is missing on '# Partition Transform Information'
- The partition transform columns header should be
'col_name,transform_type,NULL'
Testing:
- Existing tests
Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
---
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/18634/3
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11367: There should be LINE DELIM above '# Partition Transform Information'
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: There should be LINE_DELIM above '# Partition Transform Information'
......................................................................
Patch Set 1:
(1 comment)
Thanks for fixing this!
http://gerrit.cloudera.org:8080/#/c/18634/1/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java:
http://gerrit.cloudera.org:8080/#/c/18634/1/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@112
PS1, Line 112: formatColumnsHeader(info, null);
Also in the columns header we should see
# col_name transform_type NULL
https://github.com/apache/hive/blob/01b8fcffcb31cc128e71350d1b25c98b50ee85e5/iceberg/iceberg-handler/src/test/results/positive/describe_iceberg_table.q.out#L107
But we currently see:
# col_name data_type comment
--
To view, visit http://gerrit.cloudera.org:8080/18634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42
Gerrit-Change-Number: 18634
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 12:13:42 +0000
Gerrit-HasComments: Yes