You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/07/23 21:55:05 UTC
(superset) 01/01: style: make form labels not uppercase
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch rm_uppercase
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 185216dc13bd59cd2854abe4872a7945fc9a0d13
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Jul 23 14:31:39 2024 -0700
style: make form labels not uppercase
Back in https://github.com/apache/superset/pull/24736, I tried to make
form labels(headers) not use `text-transform: uppercase;`, but somehow
it got reverted. Here I'm trying to do the same and maybe push further
into tab headers.
---
.../src/BigNumber/BigNumberWithTrendline/controlPanel.tsx | 2 +-
superset-frontend/src/GlobalStyles.tsx | 2 --
superset-frontend/src/assets/stylesheets/less/cosmo/bootswatch.less | 1 -
superset-frontend/src/components/Datasource/DatasourceEditor.jsx | 2 +-
superset-frontend/src/components/Form/FormItem.tsx | 1 -
superset-frontend/src/components/Form/FormLabel.tsx | 2 --
superset-frontend/src/components/Tabs/Tabs.tsx | 1 -
.../src/features/databases/DatabaseModal/SSHTunnelForm.tsx | 1 -
superset-frontend/src/features/databases/DatabaseModal/styles.ts | 3 ---
9 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/controlPanel.tsx
index 869583f847..83cf915c7c 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/controlPanel.tsx
@@ -279,7 +279,7 @@ const config: ControlPanelConfig = {
label: t('Number format'),
},
x_axis: {
- label: t('TEMPORAL X-AXIS'),
+ label: t('Temporal X-Axis'),
...temporalColumnMixin,
},
},
diff --git a/superset-frontend/src/GlobalStyles.tsx b/superset-frontend/src/GlobalStyles.tsx
index bd882e3973..784b3d9b21 100644
--- a/superset-frontend/src/GlobalStyles.tsx
+++ b/superset-frontend/src/GlobalStyles.tsx
@@ -40,7 +40,6 @@ export const GlobalStyles = () => (
border-radius: ${theme.borderRadius}px;
background: ${theme.colors.primary.base};
border: none;
- text-transform: uppercase;
color: ${theme.colors.grayscale.light5};
line-height: 1.5715;
font-size: ${theme.typography.sizes.s}px;
@@ -53,7 +52,6 @@ export const GlobalStyles = () => (
border-radius: ${theme.borderRadius}px;
background: ${theme.colors.primary.light4};
border: none;
- text-transform: uppercase;
color: ${theme.colors.primary.dark1};
line-height: 1.5715;
font-size: ${theme.typography.sizes.s}px;
diff --git a/superset-frontend/src/assets/stylesheets/less/cosmo/bootswatch.less b/superset-frontend/src/assets/stylesheets/less/cosmo/bootswatch.less
index 26c44bdaa3..7c40b6c304 100644
--- a/superset-frontend/src/assets/stylesheets/less/cosmo/bootswatch.less
+++ b/superset-frontend/src/assets/stylesheets/less/cosmo/bootswatch.less
@@ -508,7 +508,6 @@ a {
}
.control-label {
- text-transform: uppercase;
color: @gray;
font-size: @font-size-s;
}
diff --git a/superset-frontend/src/components/Datasource/DatasourceEditor.jsx b/superset-frontend/src/components/Datasource/DatasourceEditor.jsx
index 9282fda4a9..3fa99f34f8 100644
--- a/superset-frontend/src/components/Datasource/DatasourceEditor.jsx
+++ b/superset-frontend/src/components/Datasource/DatasourceEditor.jsx
@@ -1086,7 +1086,7 @@ class DatasourceEditor extends PureComponent {
<Col xs={24} md={12}>
<Field
fieldKey="databaseSelector"
- label={t('virtual')}
+ label={t('Virtual')}
control={
<div css={{ marginTop: 8 }}>
<DatabaseSelector
diff --git a/superset-frontend/src/components/Form/FormItem.tsx b/superset-frontend/src/components/Form/FormItem.tsx
index 9b529dbd5d..dd829cd1e4 100644
--- a/superset-frontend/src/components/Form/FormItem.tsx
+++ b/superset-frontend/src/components/Form/FormItem.tsx
@@ -24,7 +24,6 @@ const StyledItem = styled(Form.Item)`
.ant-form-item-label {
padding-bottom: ${theme.gridUnit}px;
& > label {
- text-transform: uppercase;
font-size: ${theme.typography.sizes.s}px;
color: ${theme.colors.grayscale.base};
diff --git a/superset-frontend/src/components/Form/FormLabel.tsx b/superset-frontend/src/components/Form/FormLabel.tsx
index e28e9ab7b6..bf52dacb82 100644
--- a/superset-frontend/src/components/Form/FormLabel.tsx
+++ b/superset-frontend/src/components/Form/FormLabel.tsx
@@ -27,14 +27,12 @@ export type FormLabelProps = {
};
const Label = styled.label`
- text-transform: uppercase;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
color: ${({ theme }) => theme.colors.grayscale.base};
margin-bottom: ${({ theme }) => theme.gridUnit}px;
`;
const RequiredLabel = styled.label`
- text-transform: uppercase;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
color: ${({ theme }) => theme.colors.grayscale.base};
margin-bottom: ${({ theme }) => theme.gridUnit}px;
diff --git a/superset-frontend/src/components/Tabs/Tabs.tsx b/superset-frontend/src/components/Tabs/Tabs.tsx
index 33056d03c4..3af2ecec36 100644
--- a/superset-frontend/src/components/Tabs/Tabs.tsx
+++ b/superset-frontend/src/components/Tabs/Tabs.tsx
@@ -74,7 +74,6 @@ const StyledTabs = ({
justify-content: center;
font-size: ${theme.typography.sizes.s}px;
text-align: center;
- text-transform: uppercase;
user-select: none;
.required {
margin-left: ${theme.gridUnit / 2}px;
diff --git a/superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx b/superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx
index 7394c1aacb..549919ffe3 100644
--- a/superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx
+++ b/superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx
@@ -31,7 +31,6 @@ const StyledDiv = styled.div`
padding-top: ${({ theme }) => theme.gridUnit * 2}px;
label {
color: ${({ theme }) => theme.colors.grayscale.base};
- text-transform: uppercase;
margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
}
`;
diff --git a/superset-frontend/src/features/databases/DatabaseModal/styles.ts b/superset-frontend/src/features/databases/DatabaseModal/styles.ts
index e38b4d96ec..95d77781b5 100644
--- a/superset-frontend/src/features/databases/DatabaseModal/styles.ts
+++ b/superset-frontend/src/features/databases/DatabaseModal/styles.ts
@@ -465,7 +465,6 @@ export const CreateHeaderSubtitle = styled.div`
export const EditHeaderTitle = styled.div`
color: ${({ theme }) => theme.colors.grayscale.light1};
font-size: ${({ theme }) => theme.typography.sizes.s}px;
- text-transform: uppercase;
`;
export const EditHeaderSubtitle = styled.div`
@@ -480,7 +479,6 @@ export const CredentialInfoForm = styled.div`
}
.label-select {
- text-transform: uppercase;
color: ${({ theme }) => theme.colors.grayscale.dark1};
font-size: 11px;
margin: 0 5px ${({ theme }) => theme.gridUnit * 2}px;
@@ -553,7 +551,6 @@ export const SelectDatabaseStyles = styled.div`
}
.label-available-select {
- text-transform: uppercase;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
}