You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/03 16:47:17 UTC
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1096: MINIFICPP-1580 Fix Tensorflow extension build
lordgamez commented on a change in pull request #1096:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1096#discussion_r644964876
##########
File path: extensions/tensorflow/CMakeLists.txt
##########
@@ -26,7 +26,7 @@ find_package(TensorFlow REQUIRED)
message("-- Found TensorFlow: ${TENSORFLOW_INCLUDE_DIRS}")
-include_directories(${TENSORFLOW_INCLUDE_DIRS})
+include_directories(SYSTEM ${TENSORFLOW_INCLUDE_DIRS})
Review comment:
Updated in 0185ef84c7e1855c3f73fecf608e37aa4bf66ef5
##########
File path: extensions/tensorflow/TFApplyGraph.cpp
##########
@@ -194,7 +197,7 @@ int64_t TFApplyGraph::GraphReadCallback::process(const std::shared_ptr<io::BaseS
auto num_read = stream->read(reinterpret_cast<uint8_t *>(&graph_proto_buf[0]),
static_cast<int>(stream->size()));
- if (num_read != stream->size()) {
+ if (static_cast<uint64_t>(num_read) != stream->size()) {
Review comment:
Updated in 0185ef84c7e1855c3f73fecf608e37aa4bf66ef5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org