You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Vandana Ayyalasomayajula (Created) (JIRA)" <ji...@apache.org> on 2012/04/11 23:41:16 UTC

[jira] [Created] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Hive metastore does not have any log messages while shutting itself down. 
--------------------------------------------------------------------------

                 Key: HIVE-2946
                 URL: https://issues.apache.org/jira/browse/HIVE-2946
             Project: Hive
          Issue Type: Improvement
          Components: Metastore
            Reporter: Vandana Ayyalasomayajula
            Assignee: Vandana Ayyalasomayajula
            Priority: Minor


When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2946:
------------------------------

    Attachment: HIVE-2946.D2745.1.patch

avandana requested code review of "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-2946

  Added shutdown hook to log message while shutting down metastore.

  When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2745

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6273/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Hive metastore does not have any log messages while shutting itself down. 
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2946
>                 URL: https://issues.apache.org/jira/browse/HIVE-2946
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>              Labels: metastore
>         Attachments: HIVE-2946.D2745.1.patch
>
>
> When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Posted by "Ashutosh Chauhan (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan resolved HIVE-2946.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9.0

Committed to trunk and 0.9 Thanks, Vandana!
                
> Hive metastore does not have any log messages while shutting itself down. 
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2946
>                 URL: https://issues.apache.org/jira/browse/HIVE-2946
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>              Labels: metastore
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2946.D2745.1.patch, HIVE-2946.D2787.1.patch
>
>
> When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256054#comment-13256054 ] 

Phabricator commented on HIVE-2946:
-----------------------------------

ashutoshc has accepted the revision "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".

  +1 will commit soon.

REVISION DETAIL
  https://reviews.facebook.net/D2787

BRANCH
  svn

                
> Hive metastore does not have any log messages while shutting itself down. 
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2946
>                 URL: https://issues.apache.org/jira/browse/HIVE-2946
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>              Labels: metastore
>         Attachments: HIVE-2946.D2745.1.patch, HIVE-2946.D2787.1.patch
>
>
> When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256245#comment-13256245 ] 

Hudson commented on HIVE-2946:
------------------------------

Integrated in Hive-trunk-h0.21 #1380 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1380/])
    HIVE-2946 [jira] Hive metastore does not have any log messages while shutting
itself down.
(Vandana Kasavajjala via Ashutosh Chauhan)

Summary:
https://issues.apache.org/jira/browse/HIVE-2946

Addressed Ashutosh's comments.

When hive metastore is started, the event is logged with good amount of
information. But when it is stopped ( using a kill) command, no information is
being written to the logs. It will be good if we can add a shutdown event to the
HiveMetastore class.

Test Plan: EMPTY

Reviewers: JIRA, ashutoshc

Reviewed By: ashutoshc

Differential Revision: https://reviews.facebook.net/D2787 (Revision 1327323)

     Result = SUCCESS
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327323
Files : 
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

                
> Hive metastore does not have any log messages while shutting itself down. 
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2946
>                 URL: https://issues.apache.org/jira/browse/HIVE-2946
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>              Labels: metastore
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2946.D2745.1.patch, HIVE-2946.D2787.1.patch
>
>
> When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256060#comment-13256060 ] 

Phabricator commented on HIVE-2946:
-----------------------------------

avandana has committed the revision "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".

  Change committed by hashutosh.

REVISION DETAIL
  https://reviews.facebook.net/D2787

COMMIT
  https://reviews.facebook.net/rHIVE1327323

                
> Hive metastore does not have any log messages while shutting itself down. 
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2946
>                 URL: https://issues.apache.org/jira/browse/HIVE-2946
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>              Labels: metastore
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2946.D2745.1.patch, HIVE-2946.D2787.1.patch
>
>
> When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2946:
------------------------------

    Attachment: HIVE-2946.D2787.1.patch

avandana requested code review of "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-2946

  Addressed Ashutosh's comments.

  When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2787

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6315/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Hive metastore does not have any log messages while shutting itself down. 
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2946
>                 URL: https://issues.apache.org/jira/browse/HIVE-2946
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>              Labels: metastore
>         Attachments: HIVE-2946.D2745.1.patch, HIVE-2946.D2787.1.patch
>
>
> When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2946) Hive metastore does not have any log messages while shutting itself down.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252985#comment-13252985 ] 

Phabricator commented on HIVE-2946:
-----------------------------------

ashutoshc has commented on the revision "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".

INLINE COMMENTS
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:2956 Just like for start message you can also add
  if (cli.isVerbose()) {
  System.err.println(msg);
  }

REVISION DETAIL
  https://reviews.facebook.net/D2745

                
> Hive metastore does not have any log messages while shutting itself down. 
> --------------------------------------------------------------------------
>
>                 Key: HIVE-2946
>                 URL: https://issues.apache.org/jira/browse/HIVE-2946
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>              Labels: metastore
>         Attachments: HIVE-2946.D2745.1.patch
>
>
> When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira