You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/26 00:12:50 UTC

[GitHub] [calcite-avatica] zabetak commented on a change in pull request #88: [hotfix] fix typo in AbstractService

zabetak commented on a change in pull request #88: [hotfix] fix typo in AbstractService
URL: https://github.com/apache/calcite-avatica/pull/88#discussion_r268902217
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/avatica/remote/AbstractService.java
 ##########
 @@ -89,7 +89,7 @@ ColumnMetaData finagle(ColumnMetaData column) {
       case PROTOBUF:
         return column;
       default:
 
 Review comment:
   I am not a big fan of default + exception pattern for the same reasons mentioned in [Don't default that switch](https://www.youtube.com/watch?v=SpMIYtl_A98). All IDEs (for sure Elciplse and Intellij) are capable of detecting easily such cases and return an error or warning depending on the configuration. How about killing it completely? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services