You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/17 19:52:51 UTC
[GitHub] [spark] MaxGekk opened a new pull request #32213: [SPARK-35114][SQL] Add checks for ANSI intervals to `LiteralExpressionSuite`
MaxGekk opened a new pull request #32213:
URL: https://github.com/apache/spark/pull/32213
### What changes were proposed in this pull request?
In the PR, I propose to add additional checks for ANSI interval types `YearMonthIntervalType` and `DayTimeIntervalType` to `LiteralExpressionSuite`.
### Why are the changes needed?
To improve test coverage and have the same checks for ANSI types as for `CalendarIntervalType`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the modified test suite:
```
$ build/sbt "test:testOnly *LiteralExpressionSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821939160
**[Test build #137526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137526/testReport)** for PR 32213 at commit [`7f27f3f`](https://github.com/apache/spark/commit/7f27f3fc614d65224f81f87b6e8a74c736f2048b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821944237
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42100/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821885574
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42084/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821943966
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42100/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821885574
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42084/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821878544
**[Test build #137510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137510/testReport)** for PR 32213 at commit [`15b7c13`](https://github.com/apache/spark/commit/15b7c13f112a93544ff4c9e22d96bb0c2315fd34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821967494
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137526/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32213: [SPARK-35114][SQL] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821878334
**[Test build #759142773](https://github.com/MaxGekk/spark/actions/runs/759142773)** for PR 32213 at commit [`15b7c13`](https://github.com/MaxGekk/spark/commit/15b7c13f112a93544ff4c9e22d96bb0c2315fd34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821955149
GA passed. Merging to master:
<img width="799" alt="Screenshot 2021-04-18 at 11 33 14" src="https://user-images.githubusercontent.com/1580697/115139326-f04b9f80-a039-11eb-9854-ed51086f0c6c.png">
Thank you, @dongjoon-hyun for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32213: [SPARK-35114][SQL] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821878544
**[Test build #137510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137510/testReport)** for PR 32213 at commit [`15b7c13`](https://github.com/apache/spark/commit/15b7c13f112a93544ff4c9e22d96bb0c2315fd34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821967238
**[Test build #137526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137526/testReport)** for PR 32213 at commit [`7f27f3f`](https://github.com/apache/spark/commit/7f27f3fc614d65224f81f87b6e8a74c736f2048b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821944237
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42100/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821939160
**[Test build #137526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137526/testReport)** for PR 32213 at commit [`7f27f3f`](https://github.com/apache/spark/commit/7f27f3fc614d65224f81f87b6e8a74c736f2048b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32213:
URL: https://github.com/apache/spark/pull/32213#discussion_r615347314
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
##########
@@ -200,8 +204,8 @@ class LiteralExpressionSuite extends SparkFunSuite with ExpressionEvalHelper {
checkSeqLiteral(Seq(1, 2, 3), IntegerType)
checkSeqLiteral(Seq("a", "b", "c"), StringType)
checkSeqLiteral(Seq(1.0, 4.0), DoubleType)
- checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR),
- CalendarIntervalType)
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821883878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32213:
URL: https://github.com/apache/spark/pull/32213#discussion_r615310266
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
##########
@@ -200,8 +204,8 @@ class LiteralExpressionSuite extends SparkFunSuite with ExpressionEvalHelper {
checkSeqLiteral(Seq(1, 2, 3), IntegerType)
checkSeqLiteral(Seq("a", "b", "c"), StringType)
checkSeqLiteral(Seq(1.0, 4.0), DoubleType)
- checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR),
- CalendarIntervalType)
Review comment:
Could you mention this removal (replacement) in the PR description, @MaxGekk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32213:
URL: https://github.com/apache/spark/pull/32213#discussion_r615344413
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
##########
@@ -200,8 +204,8 @@ class LiteralExpressionSuite extends SparkFunSuite with ExpressionEvalHelper {
checkSeqLiteral(Seq(1, 2, 3), IntegerType)
checkSeqLiteral(Seq("a", "b", "c"), StringType)
checkSeqLiteral(Seq(1.0, 4.0), DoubleType)
- checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR),
- CalendarIntervalType)
Review comment:
@maropu I removed it because this doesn't check `CalendarIntervalType`. `elementType` is not used in `checkSeqLiteral()`, and this `checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR), CalendarIntervalType)` checks the `Long` type, actually.
I think of to improve the test by removing `elementType` at all, and check `CalendarIntervalType` via `CalendarInterval` values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32213:
URL: https://github.com/apache/spark/pull/32213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821909953
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32213:
URL: https://github.com/apache/spark/pull/32213#discussion_r615344413
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
##########
@@ -200,8 +204,8 @@ class LiteralExpressionSuite extends SparkFunSuite with ExpressionEvalHelper {
checkSeqLiteral(Seq(1, 2, 3), IntegerType)
checkSeqLiteral(Seq("a", "b", "c"), StringType)
checkSeqLiteral(Seq(1.0, 4.0), DoubleType)
- checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR),
- CalendarIntervalType)
Review comment:
@maropu (because you added the test) I removed it because this doesn't check `CalendarIntervalType`. `elementType` is not used in `checkSeqLiteral()`, and this `checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR), CalendarIntervalType)` checks the `Long` type, actually.
I think of to improve the test by removing `elementType` at all, and check `CalendarIntervalType` via `CalendarInterval` values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821943506
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42100/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821909953
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32213:
URL: https://github.com/apache/spark/pull/32213#issuecomment-821906421
**[Test build #137510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137510/testReport)** for PR 32213 at commit [`15b7c13`](https://github.com/apache/spark/commit/15b7c13f112a93544ff4c9e22d96bb0c2315fd34).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32213:
URL: https://github.com/apache/spark/pull/32213#discussion_r615347294
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
##########
@@ -188,20 +192,21 @@ class LiteralExpressionSuite extends SparkFunSuite with ExpressionEvalHelper {
checkArrayLiteral(Array(1, 2, 3))
checkArrayLiteral(Array("a", "b", "c"))
checkArrayLiteral(Array(1.0, 4.0))
- checkArrayLiteral(Array(MICROS_PER_DAY, MICROS_PER_HOUR))
+ checkArrayLiteral(Array(new CalendarInterval(1, 0, 0), new CalendarInterval(0, 1, 0)))
Review comment:
I didn't add checks for ANSI intervals because there are separate tests for that in the test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org