You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/01/31 21:09:59 UTC

[GitHub] kafka pull request #2474: KAFKA-4039: Fix deadlock during shutdown due to lo...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/2474

    KAFKA-4039: Fix deadlock during shutdown due to log truncation not allowed

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-4039-deadlock-during-shutdown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2474
    
----
commit d902c2bc81c4799ad1eb7bc7ec50e67d04d1c9c2
Author: Maysam Yabandeh <my...@dropbox.com>
Date:   2016-08-17T18:21:07Z

    KAFKA-4039: delay invocation of System.exit via FatalExitException

commit 548ddec8c8715125f25f3da3263fe4ead39deca2
Author: Maysam Yabandeh <my...@dropbox.com>
Date:   2016-08-17T22:39:12Z

    KAFKA-4039 change FatalExitException to Error

commit 08992e10eacb661d24506bff1f617f42cce02ffb
Author: Maysam Yabandeh <my...@dropbox.com>
Date:   2016-08-18T00:33:43Z

    KAFKA-4039 fix the default value of test mode in FatalExitError

commit bcf9e9d605fef9bc2cf46380767f3881eeee6313
Author: Maysam Yabandeh <my...@dropbox.com>
Date:   2016-08-18T14:26:20Z

    KAFKA-4039 mock System.exit

commit 98acc3674a610ac329935c2d3a1bbdd032685d25
Author: Maysam Yabandeh <my...@dropbox.com>
Date:   2016-08-19T14:38:33Z

    KAFKA-4039 exit inside an anonymous thread, add test for deadlock

commit 39a667eda0817bc42beaaedb962e5797b6f106e1
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-01-30T14:48:24Z

    Merge remote-tracking branch 'apache/trunk' into kafka-4039-deadlock-during-shutdown
    
    * apache/trunk: (552 commits)
      MINOR: JavaDoc markup cleanup
      KAFKA-4679: Remove unstable markers from Connect APIs
      KAFKA-4450; Add upgrade tests for 0.10.1 and rename TRUNK to DEV_BRANCH to reduce confusion
      KAFKA-4635; Client Compatibility follow-ups
      MINOR: update JavaDocs for Kafka Streams DSL helpers
      KAFKA-4557; Handle Producer.send correctly in expiry callbacks
      MINOR: Update copyright year in the NOTICE file.
      KAFKA-4664; Update docs/protocol.html with KIP-97 information
      KAFKA-4704; Coordinator cache loading fails if groupId is reused for offset storage after group is removed
      MINOR: Replace for within for each; replace if-elseif with match
      KAFKA-4644: Improve test coverage of StreamsPartitionAssignor
      MINOR: Update KTable JavaDoc
      MINOR: Include more detail in `ConfigDef.parseType` exception message
      KAFKA-4578; Upgrade notes for 0.10.2.0
      MINOR: Streams API JavaDoc improvements
      MINOR: Add Streams system test for broker backwards compatibility
      MINOR: Close create topics policy during shutdown and more tests
      MINOR: Update JavaDoc for DSL PAPI-API
      KAFKA-4636; Per listener security settings overrides (KIP-103)
      MINOR: Change logging level for ignored maybeAddMetric from debug to trace
      ...

commit 4d130ef7e990ca8215684adc36865f08caa79557
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-01-31T21:07:37Z

    Try a slightly different approach to solving the shutdown deadlock
    
    * Open the latch in `ShutdownableThread` before calling `exit`
    * Introduce `Exit` classes that perform exit/halt and can be changed in tests
    * Invoke `exit` from the calling thread instead of spawning a new thread
    * Updated the tests
    * A few clean-ups

commit 1c8032b7419874ef2c56e7cf321d39a3f64e6833
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-01-31T21:07:51Z

    A few style clean-ups

commit 50b6c571ae51d2c9f5b7288faace349acc156bc8
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-01-31T21:08:18Z

    Merge remote-tracking branch 'apache/trunk' into kafka-4039-deadlock-during-shutdown
    
    * apache/trunk:
      MINOR: Logging improvements in consumer internals
      KAFKA-2955; Add a simple ">" prompt to console producer
      KAFKA-4613: Follow-up to fix JavaDocs
      KAFKA-4613: Treat null-key records the same way for joins and aggreations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2474: KAFKA-4039: Fix deadlock during shutdown due to lo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2474


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---