You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ri...@apache.org on 2009/04/09 09:35:25 UTC
svn commit: r763545 -
/qpid/branches/0.5-release/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java
Author: ritchiem
Date: Thu Apr 9 07:35:25 2009
New Revision: 763545
URL: http://svn.apache.org/viewvc?rev=763545&view=rev
Log:
QPID-1793 : Increase logging on requeue to help diagnose what is being requeued. Not on critical path so logging should not impact performance.
Modified:
qpid/branches/0.5-release/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java
Modified: qpid/branches/0.5-release/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java
URL: http://svn.apache.org/viewvc/qpid/branches/0.5-release/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java?rev=763545&r1=763544&r2=763545&view=diff
==============================================================================
--- qpid/branches/0.5-release/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java (original)
+++ qpid/branches/0.5-release/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java Thu Apr 9 07:35:25 2009
@@ -467,7 +467,15 @@
{
if (_log.isInfoEnabled())
{
- _log.info("Requeuing " + messagesToBeDelivered.size() + " unacked messages. for " + toString());
+ // Requeue only occurs on connection close so this extra processing should not be a bottleneck
+ List ids=new LinkedList();
+ for (QueueEntry entry: messagesToBeDelivered)
+ {
+ ids.add(entry.getMessageId());
+ }
+
+ _log.info("Requeuing " + messagesToBeDelivered.size() + " unacked messages(" + ids + "). " +
+ "for " + toString());
}
if (!(_txnContext instanceof NonTransactionalContext))
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org