You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/09/01 18:13:48 UTC
[GitHub] incubator-brooklyn pull request: Couchbase
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/137
Couchbase
tweaks and fixes to #1 and #25 for couchbase, plus improved support for `Tasks.resolveValue` and DSL find-entity-in-scope methods e.g. `$brooklyn:descendant("id")`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn couchbase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit f2d05ff3d48925bffea39ec96d28345f00d3601f
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-06-19T13:38:10Z
Replaced CouchbaseLoadGenerator classes with yaml VanillaSoftwareProcess
commit fbb86438a19a693de25244d09bfe066e00d571c9
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-08-18T14:40:05Z
Splits pillowfight into separate (referable) YAML file, rebases on master
commit 4f70aa1172f0900c4a77f9c5a03d3132900c0440
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-06-20T09:34:39Z
Copied in @ZaidM's work from https://github.com/ZaidM/brooklyn/tree/couchbase-sync-gateway1
commit 7d0467d887629225b919d9fce93d5abf3c9a0b20
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-06-25T15:44:11Z
Fixed bucket creation
commit 48c22178417698c7891a4cd29ebc78d5d1db2ec9
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-01T09:43:16Z
Fixed CouchbaseSyncGateway live tests
commit 4885a798700aa22f39e030d97a2d65213ecb9a31
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-11T16:12:48Z
fixup me - temp commit
commit f23ee27b877642d794f5a209aac8f1597b59ceb8
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-08-20T10:06:16Z
Adds apache header to Ec2LiveTest, adds 'Live' group to tests
commit c720e8c80d66e145ab6c0c9160f2fa83c278c42d
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-08-29T23:01:15Z
This closes #1
commit 4734ad8932f59d228d347669e1ad8c560f06f0f3
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-08-29T23:02:03Z
This closes #25
Conflicts:
software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseClusterImpl.java - connect enrichers was removed, fixed here
commit 05a39488dca27887f563c20ad1110ed3916c25f5
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-08-29T05:32:52Z
expands power of Tasks.resolveValue with new supporting class ValueResolver, supporting timeouts on resolving value and forcing submission of execution to a task context where needed;
means that config arguments can be resolved in more places, such as effector default values from the GUI
commit c6d6cc4aa3800ac361b55956abe10f9dc8dfe7dc
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-01T10:00:39Z
expand the vocabulary for looking for entities in a given scope, simplify access to scope (use `descendant("xyz")`) and simplify access to config/attrWhenReady on the same node, and use static inner classes in YAML DSL objects
commit 94bf2998df461348102beae2a561445cd333b100
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-08-27T18:26:33Z
move pillowfight to core rather than tests
commit f51710de18fad107810670d569cbe6efc68aa56f
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-08-29T02:32:12Z
add overridable doStart to DynamicClusterImpl to facilitate custom logic to happen before expected state is RUNNING;
add a service problem-indicator rather than setting expected state ON_FIRE, and wait for queued tasks to complete before setting expected state RUNNING
commit df971f5a0972fb3e73e483489ef7e121162ae87f
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-01T15:45:59Z
better error message when can't find referenced yaml resource
commit 1064cd5df9cd3c49856efea7a1622745b0dd4ea6
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-08-29T02:36:06Z
publish connection url sensor, use that in pillowfight; and ensure nodes have their public hostname, since previously the first node uses its private ip and thus rebalance and other REST commands don't work reliably, fixing rebalance; and use better timings so it starts faster. now couchbase w pillowfight working very nicely
commit d23d5c09d2133e406d27d445979cc73e991fe185
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-01T16:10:32Z
Merge branch 'master' into couchbase
Conflicts:
core/src/main/java/brooklyn/entity/group/DynamicClusterImpl.java - imports
software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeSshDriver.java - install commands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/137#issuecomment-54144321
A couple of comments about null / absent values in Maps or Iterables, but
other than that, looks good. I particularly like the new $brooklyn:parent()
etc - I was never a fan of $brooklyn:component("parent",
"thisParameterDoesNothing")
On 1 September 2014 17:16, Alex Heneveld <no...@github.com> wrote:
> merging this, the majority of it is my review of #1
> <https://github.com/apache/incubator-brooklyn/pull/1> and #25
> <https://github.com/apache/incubator-brooklyn/pull/25>, and we have
> people actively wanting to use the couchbase support.
>
> however @Nakomis <https://github.com/Nakomis> i wouldn't mind a review of
> these commits:
>
> - ahgittin@05a3948
> <https://github.com/ahgittin/incubator-brooklyn/commit/05a39488dca27887f563c20ad1110ed3916c25f5>
> - ahgittin@c6d6cc4
> <https://github.com/ahgittin/incubator-brooklyn/commit/c6d6cc4aa3800ac361b55956abe10f9dc8dfe7dc>
> - ahgittin@1064cd5
> <https://github.com/ahgittin/incubator-brooklyn/commit/1064cd5df9cd3c49856efea7a1622745b0dd4ea6>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-brooklyn/pull/137#issuecomment-54076058>
> .
>
--
Martin Harris
Lead Software Engineer
Cloudsoft Corporation Ltd
www.cloudsoftcorp.com
Mobile: +44 (0)7989 047-855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Couchbase
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/137#issuecomment-54076058
merging this, the majority of it is my review of #1 and #25, and we have people actively wanting to use the couchbase support.
however @Nakomis i wouldn't mind a review of these commits:
* https://github.com/ahgittin/incubator-brooklyn/commit/05a39488dca27887f563c20ad1110ed3916c25f5
* https://github.com/ahgittin/incubator-brooklyn/commit/c6d6cc4aa3800ac361b55956abe10f9dc8dfe7dc
* https://github.com/ahgittin/incubator-brooklyn/commit/1064cd5df9cd3c49856efea7a1622745b0dd4ea6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---