You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/09/20 17:39:05 UTC
Review Request 68507: Pulled out nested `Framework` and `Slave`
classes in the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68507/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Repository: mesos
Description
-------
This makes clearer logic division with the allocator.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
src/master/allocator/mesos/hierarchical.cpp 0b13d044d29b6ff650ace08f4173669279dbb6bc
Diff: https://reviews.apache.org/r/68507/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68507: Pulled out nested `Framework` and `Slave`
classes in the allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68507/
-----------------------------------------------------------
(Updated Oct. 17, 2018, 4:34 p.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This makes clearer logic division with the allocator.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
src/master/allocator/mesos/hierarchical.cpp 6f389ed46683f7c642e87b673dc15307cc2b5cd6
Diff: https://reviews.apache.org/r/68507/diff/3/
Changes: https://reviews.apache.org/r/68507/diff/2-3/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68507: Pulled out nested `Framework` and `Slave`
classes in the allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68507/#review209198
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Sept. 25, 2018, 8:49 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68507/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 8:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This makes clearer logic division with the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
> src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861
>
>
> Diff: https://reviews.apache.org/r/68507/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68507: Pulled out nested `Framework` and `Slave`
classes in the allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68507/
-----------------------------------------------------------
(Updated Sept. 25, 2018, 1:49 p.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This makes clearer logic division with the allocator.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861
Diff: https://reviews.apache.org/r/68507/diff/2/
Changes: https://reviews.apache.org/r/68507/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu