You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/03 23:44:57 UTC

[GitHub] [spark] srowen commented on a change in pull request #26748: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings

srowen commented on a change in pull request #26748: [SPARK-29392][CORE][SQL][FOLLOWUP] Avoid deprecated (in 2.13) Symbol syntax 'foo in favor of simpler expression, where it generated deprecation warnings
URL: https://github.com/apache/spark/pull/26748#discussion_r353482378
 
 

 ##########
 File path: sql/core/v1.2/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
 ##########
 @@ -39,7 +39,7 @@ import org.apache.spark.sql.types._
  * OrcFilterSuite and HiveOrcFilterSuite is logically duplicated to provide the same test coverage.
  * The difference are the packages containing 'Predicate' and 'SearchArgument' classes.
  * - OrcFilterSuite uses 'org.apache.orc.storage.ql.io.sarg' package.
- * - HiveOrcFilterSuite uses 'org.apache.hadoop.hive.ql.io.sarg' package.
+ * - HiveOrcFilterSuite uses $"org".apache.hadoop.hive.ql.io.sarg' package.
 
 Review comment:
   Oops, my search and replace was too aggressive

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org