You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/09/01 11:37:41 UTC

[GitHub] [avro] lebaptiste commented on a diff in pull request #1843: AVRO-3622 (python) Fix compatibility check for schemas having or missing namespace

lebaptiste commented on code in PR #1843:
URL: https://github.com/apache/avro/pull/1843#discussion_r960544168


##########
lang/py/avro/test/test_schema.py:
##########
@@ -629,6 +641,10 @@ def test_invalid_name(self):
             None,
             None,
         )
+        # A name cannot start with dot."

Review Comment:
   > A few lines later, the spec says:
   > 
   > > The null namespace may not be used in a dot-separated sequence of names.
   
   This is consistent with the canonical form detailed here: https://avro.apache.org/docs/1.11.1/specification/_print/#transforming-into-parsing-canonical-form
   
   One would assume that a schema and its canonical form must have the same validation result? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org