You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lukas Theussl (JIRA)" <ji...@codehaus.org> on 2007/07/14 11:26:13 UTC
[jira] Created: (DOXIA-134) Apt parser issues
Apt parser issues
-----------------
Key: DOXIA-134
URL: http://jira.codehaus.org/browse/DOXIA-134
Project: doxia
Issue Type: Bug
Components: Module - Apt
Affects Versions: 1.0-alpha-8
Reporter: Lukas Theussl
Fix For: 1.0-beta-1
Attachments: actual.txt, expected.txt
I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:
# the parser swallows newlines between text elements
# a paragraph within a list item is swallowed
# verbatim text within a definition list item is not processed correctly
# the closing of a definition list is not processed correctly
# table header cells are not recognized and newlines within table cells are not processed correctly
Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).
Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-134) Apt parser issues
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_114143 ]
Lukas Theussl commented on DOXIA-134:
-------------------------------------
r596011 fixed points 2. and 4. The only two issues remaining are lineBreaks in table cells and verbatim blocks.
> Apt parser issues
> -----------------
>
> Key: DOXIA-134
> URL: http://jira.codehaus.org/browse/DOXIA-134
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Apt
> Affects Versions: 1.0-alpha-8
> Reporter: Lukas Theussl
> Fix For: 1.0-beta-1
>
> Attachments: actual.txt, DOXIA-134-headerCell.patch, expected.txt
>
>
> I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:
> # the parser swallows newlines between text elements
> # a paragraph within a list item is swallowed
> # verbatim text within a definition list item is not processed correctly
> # the closing of a definition list is not processed correctly
> # table header cells are not recognized and newlines within table cells are not processed correctly
> Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).
> Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DOXIA-134) Apt parser issues
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton closed DOXIA-134.
---------------------------------
Assignee: Vincent Siveton
Resolution: Fixed
Fix Version/s: (was: 1.2)
1.1.1
I fixed the issues about multiline and linebreak in table cells in [r773851|http://svn.apache.org/viewvc?rev=773851&view=rev]
> Apt parser issues
> -----------------
>
> Key: DOXIA-134
> URL: http://jira.codehaus.org/browse/DOXIA-134
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Apt
> Affects Versions: 1.0-alpha-8
> Reporter: Lukas Theussl
> Assignee: Vincent Siveton
> Fix For: 1.1.1
>
> Attachments: actual.txt, DOXIA-134-headerCell.patch, expected.txt
>
>
> I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:
> # the parser swallows newlines between text elements
> # a paragraph within a list item is swallowed
> # verbatim text within a definition list item is not processed correctly
> # the closing of a definition list is not processed correctly
> # table header cells are not recognized and newlines within table cells are not processed correctly
> Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).
> Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-134) Apt parser issues
Posted by "Denis Cabasson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Cabasson updated DOXIA-134:
---------------------------------
Attachment: DOXIA-134-headerCell.patch
submitted patch should correct (at least to some extend) point 5, handling headerCells in AptSink.
Point 1 looks sensible to me (stripping non significant EOL).
Could you attach a full test case so I can try to re-play it?
> Apt parser issues
> -----------------
>
> Key: DOXIA-134
> URL: http://jira.codehaus.org/browse/DOXIA-134
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Apt
> Affects Versions: 1.0-alpha-8
> Reporter: Lukas Theussl
> Fix For: 1.0-beta-1
>
> Attachments: actual.txt, DOXIA-134-headerCell.patch, expected.txt
>
>
> I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:
> # the parser swallows newlines between text elements
> # a paragraph within a list item is swallowed
> # verbatim text within a definition list item is not processed correctly
> # the closing of a definition list is not processed correctly
> # table header cells are not recognized and newlines within table cells are not processed correctly
> Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).
> Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-134) Apt parser issues
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103317 ]
Lukas Theussl commented on DOXIA-134:
-------------------------------------
The classes I used to generate those files are in SVN now, just run 'mvn test' in the apt module.
> Apt parser issues
> -----------------
>
> Key: DOXIA-134
> URL: http://jira.codehaus.org/browse/DOXIA-134
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Apt
> Affects Versions: 1.0-alpha-8
> Reporter: Lukas Theussl
> Fix For: 1.0-beta-1
>
> Attachments: actual.txt, DOXIA-134-headerCell.patch, expected.txt
>
>
> I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:
> # the parser swallows newlines between text elements
> # a paragraph within a list item is swallowed
> # verbatim text within a definition list item is not processed correctly
> # the closing of a definition list is not processed correctly
> # table header cells are not recognized and newlines within table cells are not processed correctly
> Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).
> Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-134) Apt parser issues
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103027 ]
Lukas Theussl commented on DOXIA-134:
-------------------------------------
Patch applied, thanks!
I need to do some house cleaning but I will soon attach a more complete patch to DOXIA-101, that will allow you to re-produce my results.
> Apt parser issues
> -----------------
>
> Key: DOXIA-134
> URL: http://jira.codehaus.org/browse/DOXIA-134
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Apt
> Affects Versions: 1.0-alpha-8
> Reporter: Lukas Theussl
> Fix For: 1.0-beta-1
>
> Attachments: actual.txt, DOXIA-134-headerCell.patch, expected.txt
>
>
> I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:
> # the parser swallows newlines between text elements
> # a paragraph within a list item is swallowed
> # verbatim text within a definition list item is not processed correctly
> # the closing of a definition list is not processed correctly
> # table header cells are not recognized and newlines within table cells are not processed correctly
> Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).
> Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-134) Apt parser issues
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=136781#action_136781 ]
Lukas Theussl commented on DOXIA-134:
-------------------------------------
Verbatim blocks are fixed in r661590, only the issue with lineBreaks in table cells remains...
> Apt parser issues
> -----------------
>
> Key: DOXIA-134
> URL: http://jira.codehaus.org/browse/DOXIA-134
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Apt
> Affects Versions: 1.0-alpha-8
> Reporter: Lukas Theussl
> Fix For: 1.0-beta-2
>
> Attachments: actual.txt, DOXIA-134-headerCell.patch, expected.txt
>
>
> I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:
> # the parser swallows newlines between text elements
> # a paragraph within a list item is swallowed
> # verbatim text within a definition list item is not processed correctly
> # the closing of a definition list is not processed correctly
> # table header cells are not recognized and newlines within table cells are not processed correctly
> Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).
> Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira