You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Radu Manole <ma...@gmail.com> on 2015/07/02 15:14:43 UTC
Re: Review Request 36002: OODT-855: Avrorpc communication channel for
catalog
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36002/
-----------------------------------------------------------
(Updated July 2, 2015, 1:14 p.m.)
Review request for oodt, Lewis McGibbney and Chris Mattmann.
Bugs: OODT-855
https://issues.apache.org/jira/browse/OODT-855
Repository: oodt
Description
-------
using String parameters and serializing objects with Serializer.
Diffs
-----
trunk/catalog/pom.xml 1688032
trunk/catalog/src/main/avro/CommunicationChannel.avpr PRE-CREATION
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClient.java PRE-CREATION
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClientFactory.java PRE-CREATION
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServer.java PRE-CREATION
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServerFactory.java PRE-CREATION
trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/TestAvrorpcCommunicationChannelServer.java PRE-CREATION
trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/system/impl/TestCatalogServiceLocal.java 1688032
Diff: https://reviews.apache.org/r/36002/diff/
Testing
-------
Unit tests.
Thanks,
Radu Manole
Re: Review Request 36002: OODT-855: Avrorpc communication channel for
catalog
Posted by Lewis McGibbney <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36002/#review99161
-----------------------------------------------------------
Ship it!
Ship It!
- Lewis McGibbney
On July 2, 2015, 1:14 p.m., Radu Manole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36002/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 1:14 p.m.)
>
>
> Review request for oodt, Lewis McGibbney and Chris Mattmann.
>
>
> Bugs: OODT-855
> https://issues.apache.org/jira/browse/OODT-855
>
>
> Repository: oodt
>
>
> Description
> -------
>
> using String parameters and serializing objects with Serializer.
>
>
> Diffs
> -----
>
> trunk/catalog/pom.xml 1688032
> trunk/catalog/src/main/avro/CommunicationChannel.avpr PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClient.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClientFactory.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServer.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServerFactory.java PRE-CREATION
> trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/TestAvrorpcCommunicationChannelServer.java PRE-CREATION
> trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/system/impl/TestCatalogServiceLocal.java 1688032
>
> Diff: https://reviews.apache.org/r/36002/diff/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Radu Manole
>
>
Re: Review Request 36002: OODT-855: Avrorpc communication channel for
catalog
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36002/#review90217
-----------------------------------------------------------
trunk/catalog/src/main/avro/CommunicationChannel.avpr (line 1)
<https://reviews.apache.org/r/36002/#comment143230>
ALv2 license header needed.
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClient.java (line 1)
<https://reviews.apache.org/r/36002/#comment143229>
ALv2 license header needed.
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClientFactory.java (line 1)
<https://reviews.apache.org/r/36002/#comment143231>
ALv2 license header needed.
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServer.java (line 1)
<https://reviews.apache.org/r/36002/#comment143232>
ALv2 license header needed.
trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServerFactory.java (line 1)
<https://reviews.apache.org/r/36002/#comment143233>
ALv2 license header needed.
trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/TestAvrorpcCommunicationChannelServer.java (line 1)
<https://reviews.apache.org/r/36002/#comment143234>
ALv2 license header needed.
- Chris Mattmann
On July 2, 2015, 1:14 p.m., Radu Manole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36002/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 1:14 p.m.)
>
>
> Review request for oodt, Lewis McGibbney and Chris Mattmann.
>
>
> Bugs: OODT-855
> https://issues.apache.org/jira/browse/OODT-855
>
>
> Repository: oodt
>
>
> Description
> -------
>
> using String parameters and serializing objects with Serializer.
>
>
> Diffs
> -----
>
> trunk/catalog/pom.xml 1688032
> trunk/catalog/src/main/avro/CommunicationChannel.avpr PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClient.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClientFactory.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServer.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServerFactory.java PRE-CREATION
> trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/TestAvrorpcCommunicationChannelServer.java PRE-CREATION
> trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/system/impl/TestCatalogServiceLocal.java 1688032
>
> Diff: https://reviews.apache.org/r/36002/diff/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Radu Manole
>
>
Re: Review Request 36002: OODT-855: Avrorpc communication channel for
catalog
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36002/#review90218
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Mattmann
On July 2, 2015, 1:14 p.m., Radu Manole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36002/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 1:14 p.m.)
>
>
> Review request for oodt, Lewis McGibbney and Chris Mattmann.
>
>
> Bugs: OODT-855
> https://issues.apache.org/jira/browse/OODT-855
>
>
> Repository: oodt
>
>
> Description
> -------
>
> using String parameters and serializing objects with Serializer.
>
>
> Diffs
> -----
>
> trunk/catalog/pom.xml 1688032
> trunk/catalog/src/main/avro/CommunicationChannel.avpr PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClient.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelClientFactory.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServer.java PRE-CREATION
> trunk/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/AvrorpcCommunicationChannelServerFactory.java PRE-CREATION
> trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/server/channel/avrorpc/TestAvrorpcCommunicationChannelServer.java PRE-CREATION
> trunk/catalog/src/test/java/org/apache/oodt/cas/catalog/system/impl/TestCatalogServiceLocal.java 1688032
>
> Diff: https://reviews.apache.org/r/36002/diff/
>
>
> Testing
> -------
>
> Unit tests.
>
>
> Thanks,
>
> Radu Manole
>
>