You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/03/30 15:01:38 UTC
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/343
Mango: creation and listing of indexes
Part 1/2 for Mango:
Creation of Mango indexes and listing them. Disabled pagination
and bulk-deletion for now, see:
https://issues.apache.org/jira/browse/COUCHDB-2651
https://issues.apache.org/jira/browse/COUCHDB-2652
As you can't use the feature right now (querying is part 2/2)
the buttons to reach the features are hidden behind a feature flip.
Use the direct urls to access the features:
http://localhost:8000/#database/$YOUR_DATABASE/_index
http://localhost:8000/#database/$YOUR_DATABASE/_indexlist
or add `?beta=showquery` to your url, e.g.
http://localhost:8000/#database/$YOUR_DATABASE/?beta=showquery
Additionally prepares the app for i18n.
COUCHDB-2627
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton mango-tropical-fruits
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit 330c2585a77d03bbf7f66ebd22fd0f0ffc39836e
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-03-27T13:16:43Z
Mango: creation and listing of indexes
Part 1/2 for Mango:
Creation of Mango indexes and listing them. Disabled pagination
and bulk-deletion for now, see:
https://issues.apache.org/jira/browse/COUCHDB-2651
https://issues.apache.org/jira/browse/COUCHDB-2652
As you can't use the feature right now (querying is part 2/2)
the buttons to reach the features are hidden behind a feature flip.
Use the direct urls to access the features:
http://localhost:8000/#database/$YOUR_DATABASE/_index
http://localhost:8000/#database/$YOUR_DATABASE/_indexlist
or add `?beta=showquery` to your url, e.g.
http://localhost:8000/#database/$YOUR_DATABASE/?beta=showquery
Additionally prepares the app for i18n.
COUCHDB-2627
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/343#discussion_r27465462
--- Diff: app/addons/components/assets/less/header-togglebutton.less ---
@@ -11,6 +11,8 @@
// the License.
@import "../../../../../assets/less/variables.less";
+@import "../../../../../assets/less/variables.less";
--- End diff --
You do need to import this twice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/343#issuecomment-88100791
@garrensmith i removed the flip and added a help screen instead of a list of indexes:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/343#discussion_r27465620
--- Diff: app/addons/documents/base.js ---
@@ -110,5 +110,24 @@ function (app, FauxtonAPI, Documents) {
return '/database/' + database + '/' ;
},
});
+
+ FauxtonAPI.registerUrls('mango', {
+ 'index-apiurl': function (db, query) {
+ if (!query) {
+ query = '';
+ }
+
+ return window.location.origin + '/' + db + '/_index' + query;
+ },
+
+ 'index-app': function (db, query) {
+ if (!query) {
+ query = '';
+ }
+
+ return 'database/' + db + '/_index' + query;
+ }
+ });
--- End diff --
Don't you need a url for the server?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/343#issuecomment-88129926
merged as d7641f16e7a12faff896136826b43f7affb0a393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/343#issuecomment-88102492
+1 once tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Mango: creation and listing of index...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/343#discussion_r27465543
--- Diff: app/addons/components/tests/docSpec.react.jsx ---
@@ -81,12 +81,23 @@ define([
var spy = sinon.spy();
el = TestUtils.renderIntoDocument(
- <ReactComponents.Document onDoubleClick={spy} docIdentifier="foo" />,
+ <ReactComponents.Document isDeletable={true} onDoubleClick={spy} docIdentifier="foo" />,
container
);
React.addons.TestUtils.Simulate.doubleClick(el.getDOMNode());
assert.ok(spy.calledOnce);
});
+
+ it('it can render without checkbox', function () {
--- End diff --
You don't need the extra 'it' in the statement. Its there already :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---