[jira] [Updated] (STORM-2358) Update storm hdfs spout to remove specific implementation handlings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated STORM-2358:
----------------------------------
    Labels: newbie pull-request-available  (was: newbie)

> Update storm hdfs spout to remove specific implementation handlings
> -------------------------------------------------------------------
>
>                 Key: STORM-2358
>                 URL: https://issues.apache.org/jira/browse/STORM-2358
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-hdfs
>    Affects Versions: 1.x
>            Reporter: Sachin Pasalkar
>            Priority: Major
>              Labels: newbie, pull-request-available
>         Attachments: AbstractFileReader.java, FileReader.java, HDFSSpout.java, SequenceFileReader.java, TextFileReader.java
>
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> I was looking at storm hdfs spout code in 1.x branch, I found below
> improvements can be made in below code.
>   1.  Make org.apache.storm.hdfs.spout.AbstractFileReader as public so
> that it can be used in generics.
>   2.  org.apache.storm.hdfs.spout.HdfsSpout requires readerType as
> String. It will be great to have class<? extends AbstractFileReader>
> readerType; So we will not use Class.forName at multiple places also it
> will help in below point.
>   3.  HdfsSpout also needs to provide outFields which are declared as
> constants in each reader(e.g.SequenceFileReader). We can have abstract
> API AbstractFileReader in which return them to user to make it generic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)