[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #9271: [Feature-wip] CTAS support insert data

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #9271:
URL: https://github.com/apache/incubator-doris/pull/9271#discussion_r860969583


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##########
@@ -62,17 +73,6 @@ public void analyze(Analyzer analyzer) throws UserException {
         if (columnNames != null && columnNames.size() != resultExprs.size()) {
             ErrorReport.reportAnalysisException(ErrorCode.ERR_COL_NUMBER_NOT_MATCH);
         }
-    }
-    
-    public CreateTableStmt getCreateTableStmt() {
-        return createTableStmt;
-    }
-    
-    public List<String> getColumnNames() {
-        return columnNames;
-    }
-    
-    public QueryStmt getQueryStmt() {
-        return queryStmt;
+        // Cannot analyze insertStmt because the table has not been created yet

Review Comment:
   i think make this comment as a method function should be better



##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##########
@@ -17,6 +17,8 @@
 
 package org.apache.doris.analysis;
 
+import lombok.Getter;
+
 import org.apache.doris.common.ErrorCode;

Review Comment:
   import order should be
   doris
   
   third party
   
   java



##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1237,7 +1240,8 @@ private void handleInsertStmt() throws Exception {
         context.getMysqlChannel().reset();
         // create plan
         InsertStmt insertStmt = (InsertStmt) parsedStmt;
-
+    
+        LOG.info("insertStmt={}", insertStmt.toSql());

Review Comment:
   should we set this log level to debug?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org