You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/06/13 08:09:49 UTC

[GitHub] [doris] yiguolei commented on a diff in pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed

yiguolei commented on code in PR #20742:
URL: https://github.com/apache/doris/pull/20742#discussion_r1227710711


##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -220,7 +220,11 @@ class RuntimeFilterSlotsBase {
     Status publish() {
         for (auto& pair : _runtime_filters) {
             for (auto filter : pair.second) {
-                RETURN_IF_ERROR(filter->publish());
+                auto state = filter->publish();

Review Comment:
   use status  not state



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org