You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by GitBox <gi...@apache.org> on 2020/12/22 07:28:34 UTC
[GitHub] [pdfbox] arturobernalg opened a new pull request #95: [PDFBOX-5055] - Minor Improvement:
arturobernalg opened a new pull request #95:
URL: https://github.com/apache/pdfbox/pull/95
* Add final
* Unnecessary semicolon ';'
* Remove Unnecessary interface modifier
* Remove Unnecessary semicolon
* Remove Unused import
* Use Standard Charset Object
* Change License to Text Plain
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] arturobernalg closed pull request #95: [PDFBOX-5055] - Minor Improvement:
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #95:
URL: https://github.com/apache/pdfbox/pull/95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] rototor commented on pull request #95: [PDFBOX-5055] - Minor Improvement:
Posted by GitBox <gi...@apache.org>.
rototor commented on pull request #95:
URL: https://github.com/apache/pdfbox/pull/95#issuecomment-749498208
@arturobernalg I don't want to disappoint you, but this project does not use the GitHub PullRequests (They are ignored). Instead you should open a JIRA Ticket at https://issues.apache.org/jira/projects/PDFBOX and attach you changes as a patch.
And of course, you must first sign the Apache CLA. See here https://www.apache.org/licenses/contributor-agreements.html
Your three PullRequests are way too big to be reviewed. You must provide small step-by-step patches. Otherwise you risk that your contribution is ignored. And you should expect some delays after you attached a patch, as AFAIK no one is paid to work full time on this project.
Note: I'm not a PDFBox maintainer, just a on and off contributor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] arturobernalg commented on pull request #95: [PDFBOX-5055] - Minor Improvement:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #95:
URL: https://github.com/apache/pdfbox/pull/95#issuecomment-749578625
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] [pdfbox] THausherr commented on pull request #95: [PDFBOX-5055] - Minor Improvement:
Posted by GitBox <gi...@apache.org>.
THausherr commented on pull request #95:
URL: https://github.com/apache/pdfbox/pull/95#issuecomment-749575961
@rototor ICLA is for bigger changes (like the ones you thankfully did), not for small bugfixes and cleanups and code quality improvements. In the meantime I committed most of his suggestions by searching for them. But not the "final" thing, which I mostly don't like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org