You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/04 10:39:44 UTC
[GitHub] [dolphinscheduler] XuXuClassMate opened a new pull request, #10773: fix langage matched
XuXuClassMate opened a new pull request, #10773:
URL: https://github.com/apache/dolphinscheduler/pull/10773
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] XuXuClassMate commented on pull request #10773: fix langage matched
Posted by GitBox <gi...@apache.org>.
XuXuClassMate commented on PR #10773:
URL: https://github.com/apache/dolphinscheduler/pull/10773#issuecomment-1173659739
https://github.com/apache/dolphinscheduler/issues/10770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10773: fix langage matched
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10773:
URL: https://github.com/apache/dolphinscheduler/pull/10773#discussion_r912954602
##########
dolphinscheduler-ui-next/src/utils/common.ts:
##########
@@ -0,0 +1,352 @@
+/*
Review Comment:
`dolphinscheduler-ui-next` no longer exists in the dev branch.
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/TaskParametersUtils.java:
##########
@@ -0,0 +1,103 @@
+/*
Review Comment:
Please remove unnessnary file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] XuXuClassMate closed pull request #10773: [Fix-10770] [UI] Fix language not matched
Posted by GitBox <gi...@apache.org>.
XuXuClassMate closed pull request #10773: [Fix-10770] [UI] Fix language not matched
URL: https://github.com/apache/dolphinscheduler/pull/10773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org