You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/06/11 19:36:29 UTC

[GitHub] spark pull request #21438: [SPARK-24398] [SQL] Improve SQLAppStatusListener....

Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21438#discussion_r194522227
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala ---
    @@ -159,7 +159,7 @@ class SQLAppStatusListener(
       }
     
       private def aggregateMetrics(exec: LiveExecutionData): Map[Long, String] = {
    -    val metricIds = exec.metrics.map(_.accumulatorId).sorted
    +    val metricIds = exec.metrics.map(_.accumulatorId).toSet
    --- End diff --
    
    +1， we can use `metricTypes`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org