[jira] [Commented] (BAHIR-141) Support for Array[Byte] in SparkGCPCredentials.jsonServiceAccount

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BAHIR-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726764#comment-16726764 ] 

ASF GitHub Bot commented on BAHIR-141:
--------------------------------------

Github user lukasz-antoniak commented on the issue:

    https://github.com/apache/bahir/pull/53
  
    @ankitagr2312: Since the last update is already one year old, do you plan to
    work on this JIRA ticket and pull request? If not, do you agree that I take it from here?
    
    1) I think that `ServiceAccountCredentials` could be divided into two separate implementations of `SparkGPCCredentials` interface. First implementation `JsonConfigCredentials` would accept either path to JSON file or binary content. Second implementation `EmailPrivateKeyCredentials` would require passing email address and path to P12 key or binary content of the key.
    
    2) Can you revert to original formatting of lines that you did not mean to modify?
    
    3) Update the _README.md_ to include new feature? Undocumented feature is not a feature :).


> Support for Array[Byte] in SparkGCPCredentials.jsonServiceAccount
> -----------------------------------------------------------------
>
>                 Key: BAHIR-141
>                 URL: https://issues.apache.org/jira/browse/BAHIR-141
>             Project: Bahir
>          Issue Type: Improvement
>          Components: Spark Streaming Connectors
>    Affects Versions: Spark-2.0.2, Spark-2.1.1, Spark-2.2.0
>            Reporter: Ankit Agrahari
>            Priority: Minor
>             Fix For: Spark-2.0.2, Spark-2.2.0
>
>
> Existing implementation of SparkGCPCredentials.jsonServiceAccount has only support for reading the credential file from given path in config(i.e local path). If developer does not have access to worker node it makes easy for developer to add the byte array of json service file rather than path(which will not be available on worker node and will lead to FileNotFound Exaception)from the machine where driver is submitting job from.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)