[GitHub] spark pull request: [SPARK-4508] [SQL] build native date type to c...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/3381#issuecomment-67383123
  
    Hi @adrian-wang, thanks for working on this and I'm very sorry for letting it fall out of date.  In general this seems like a reasonable change to make, but we do need to be very careful that we don't change the output types as those are part of the public API.  I could be wrong, but it doesn't seem like we are doing that now.
    
    So I propose the following:
     - Close this issue for now, and reopen it once it has been updated.  (we are trying very hard to keep the PR queue small and limited to active PRs so that things don't fall through the cracks).
     - Add tests to scala/java/python to make sure we are not changing the types that are output.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org