You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/06/09 14:22:23 UTC

[Bug 55085] New: UX Improvement : New from Templates

https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

            Bug ID: 55085
           Summary: UX Improvement : New from Templates
           Product: JMeter
           Version: 2.9
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: support@ubikloadpack.com

Hello,
We implemented a new Menu Option called "New from Templates"
The idea is the following (similar to first step described in Bug 55028):
- User can select from a set of configurable templates one that fits his use
case
- When he select create, the template is copied to the user.dir folder and
opened in JMeter, user can modify it.


For now there is no GUI to create new template but it can be done through
edition of templates.xml file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #18 from Milamber <mi...@apache.org> ---
URL: http://svn.apache.org/r1505338
Log:
UX Improvement : Ability to create New Test Plan from Templates
Rename "Create from templates" to Templates (internally)
Bugzilla Id: 55085

Added:
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java  
(contents, props changed)
      - copied, changed from r1505328,
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/TemplatesCommand.java  
(contents, props changed)
      - copied, changed from r1505328,
jmeter/trunk/src/core/org/apache/jmeter/gui/action/TemplateCommand.java
Removed:
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/TemplateCommand.java
Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/reso

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Mon Jul  8 19:59:52 2013
New Revision: 1500919

URL: http://svn.apache.org/r1500919
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Added documentation
Bugzilla Id: 55085

Modified:
    jmeter/trunk/xdocs/usermanual/get-started.xml


Date: Mon Jul  8 20:02:04 2013
New Revision: 1500922

URL: http://svn.apache.org/r1500922
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Added documentation
Bugzilla Id: 55085

Added:
    jmeter/trunk/xdocs/images/screenshots/template_menu.png   (with props)
    jmeter/trunk/xdocs/images/screenshots/template_wizard.png   (with props)


Date: Mon Jul  8 20:03:16 2013
New Revision: 1500924

URL: http://svn.apache.org/r1500924
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Added screenshot
Bugzilla Id: 55085

Added:
    jmeter/trunk/docs/images/screenshots/template_menu.png   (with props)
    jmeter/trunk/docs/images/screenshots/template_wizard.png   (with props)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sun Jun 30 18:42:53 2013
New Revision: 1498168

URL: http://svn.apache.org/r1498168
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
add templates to distribution
Bugzilla Id: 55085

Modified:
    jmeter/trunk/build.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Sebb <se...@apache.org> ---
URL: http://svn.apache.org/r1501238
Log:
UX Improvement : Ability to create New Test Plan from Templates
Change preferred size so existing templates fit better
Bugzilla Id: 55085

Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : New from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #2 from UbikLoadPack support <su...@ubikloadpack.com> ---
Created attachment 30422
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30422&action=edit
Screenshot of New menu

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : New from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #3 from UbikLoadPack support <su...@ubikloadpack.com> ---
Created attachment 30423
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30423&action=edit
Screenshot of Create from Template Popup

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UX Improvement : New from   |UX Improvement : Ability to
                   |Templates                   |create New Test Plan from
                   |                            |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

Milamber <mi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #6 from Milamber <mi...@apache.org> ---


If you run a ant distribution task, the "bin/templates" directory aren't
include in archive (tar.gz). 
And you have this error message on GUI :
Sorry, this feature (create_from_template) not yet implemented

I think, this (great) feature needs some documentation in user manual.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : New from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #9 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sat Jul  6 19:36:27 2013
New Revision: 1500318

URL: http://svn.apache.org/r1500318
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Fixed missing " check if the test plan has been saved before replacing it"
Bugzilla Id: 55085

Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sat Jun 29 20:08:15 2013
New Revision: 1498018

URL: http://svn.apache.org/r1498018
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Bugzilla Id: 55085

Added:
    jmeter/trunk/bin/templates/
    jmeter/trunk/bin/templates/jdbc.jmx
    jmeter/trunk/bin/templates/recording.jmx
    jmeter/trunk/bin/templates/templates.xml   (with props)
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java  
(with props)
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/TemplateCommand.java  
(with props)
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/template/
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/template/Template.java  
(with props)
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/template/TemplateManager.java
  (with props)
Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/xdocs/changes.xml


Date: Sat Jun 29 20:11:43 2013
New Revision: 1498019

URL: http://svn.apache.org/r1498019
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Set svn:eol-type
Bugzilla Id: 55085

Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java  
(props changed)
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/TemplateCommand.java  
(props changed)
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/template/Template.java  
(props changed)
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/template/TemplateManager.java
  (props changed)

Date: Sat Jun 29 20:19:02 2013
New Revision: 1498022

URL: http://svn.apache.org/r1498022
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Set svn properties
Bugzilla Id: 55085

Modified:
    jmeter/trunk/bin/templates/jdbc.jmx   (props changed)
    jmeter/trunk/bin/templates/recording.jmx   (props changed)
    jmeter/trunk/bin/templates/templates.xml   (props changed)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #11 from Milamber <mi...@apache.org> ---


If the Template dialog box has a landscape orientation, I think that would be
better to read the description.


I think too, the first template in combo box must be the Recording template.
(perhaps rename "01-Recording")

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #16 from Milamber <mi...@apache.org> ---
URL: http://svn.apache.org/r1501297
Log:
UX Improvement : Ability to create New Test Plan from Templates
Simplify swing objects. Let's ComponentUtil sizing the dialog box.
Bugzilla Id: 55085

Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #17 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Wed Jul 10 20:55:39 2013
New Revision: 1501989

URL: http://svn.apache.org/r1501989
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Handle opening of browser on link clicking
Bugzilla Id: 55085

Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #12 from Sebb <se...@apache.org> ---
(In reply to Milamber from comment #11)
> 
> 
> I think too, the first template in combo box must be the Recording template.
> (perhaps rename "01-Recording")

Renaming won't work as they are stored in a HashMap.
Perhaps use LinkedHashMap? Or a List?
Also the method getTemplateNames needs to return a List or Array

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #19 from Milamber <mi...@apache.org> ---
URL: http://svn.apache.org/r1505341
Log:
UX Improvement : Ability to create New Test Plan from Templates
Add icon's templates to bar menu
Bugzilla Id: 55085

Added:
    jmeter/trunk/src/core/org/apache/jmeter/images/toolbar/templates.png  
(with props)
Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/images/toolbar/icons-toolbar.properties

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #8 from Sebb <se...@apache.org> ---
The Menu item "New from Templates" does not check if the test plan has been
saved before replacing it, so it is possible to lose edits.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #14 from Sebb <se...@apache.org> ---
URL: http://svn.apache.org/r1501226
Log:
UX Improvement : Ability to create New Test Plan from Templates
TemplateManager now returns templates in the order they are defined
Bugzilla Id: 55085

URL: http://svn.apache.org/r1501228
Log:
UX Improvement : Ability to create New Test Plan from Templates
Document why we don't use interface type Map for Templates#templates
Bugzilla Id: 55085

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #13 from Sebb <se...@apache.org> ---
(In reply to Sebb from comment #12)
> (In reply to Milamber from comment #11)
> > 
> > 
> > I think too, the first template in combo box must be the Recording template.
> > (perhaps rename "01-Recording")
> 
> Renaming won't work as they are stored in a HashMap.
> Perhaps use LinkedHashMap? Or a List?
> Also the method getTemplateNames needs to return a List or Array

Sorry, had overlooked the sort in SelectTemplateDialog.

However, I think it would be better to allow the template provider to specify
the ordering within the xml files; i.e. the correct order should be returned by
getTemplateNames.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : New from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

UbikLoadPack support <su...@ubikloadpack.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |support@ubikloadpack.com

--- Comment #1 from UbikLoadPack support <su...@ubikloadpack.com> ---
Created attachment 30421
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30421&action=edit
Patch implementing reported bug

UBIK-INGENIERIE/UBIKLOADPACK grants the full rights to Apache to use the
attached code and releases any rights associated to this patch.

Is there something else we need to send ?
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : Ability to create New Test Plan from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

--- Comment #20 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sat Aug  3 12:41:36 2013
New Revision: 1509971

URL: http://svn.apache.org/r1509971
Log:
Bug 55085 - UX Improvement : Ability to create New Test Plan from Templates
Add Webservice Template (not using deprecated Webservice Sampler)
Enhance web test plan to show more features
Bugzilla Id: 55085

Added:
    jmeter/trunk/bin/templates/build-webservice-test-plan.jmx
Modified:
    jmeter/trunk/bin/templates/build-web-test-plan.jmx
    jmeter/trunk/bin/templates/templates.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55085] UX Improvement : New from Templates

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55085

UbikLoadPack support <su...@ubikloadpack.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |55028

-- 
You are receiving this mail because:
You are the assignee for the bug.