[GitHub] [flink] dawidwys commented on a change in pull request #19273: [FLINK-25256][streaming] Externally induced sources replay barriers received over RPC instead of inventing them out of thin air. [1.14]

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #19273:
URL: https://github.com/apache/flink/pull/19273#discussion_r838210704



##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/ExternallyInducedSourceOperatorStreamTaskTest.java
##########
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.tasks;
+
+import org.apache.flink.api.connector.source.Boundedness;
+import org.apache.flink.api.connector.source.ExternallyInducedSourceReader;
+import org.apache.flink.api.connector.source.ReaderOutput;
+import org.apache.flink.api.connector.source.SourceReader;
+import org.apache.flink.api.connector.source.SourceReaderContext;
+import org.apache.flink.api.connector.source.mocks.MockSource;
+import org.apache.flink.api.connector.source.mocks.MockSourceSplit;
+import org.apache.flink.core.io.InputStatus;
+import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
+import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.checkpoint.CheckpointType;
+import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
+import org.apache.flink.runtime.state.CheckpointStorageLocationReference;
+import org.apache.flink.streaming.api.operators.SourceOperator;
+
+import org.hamcrest.Matchers;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
+import org.junit.runners.Parameterized.Parameters;
+
+import java.io.Serializable;
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import static org.apache.flink.runtime.checkpoint.CheckpointType.SAVEPOINT;
+import static org.apache.flink.runtime.checkpoint.CheckpointType.SAVEPOINT_SUSPEND;
+import static org.apache.flink.runtime.checkpoint.CheckpointType.SAVEPOINT_TERMINATE;
+import static org.apache.flink.streaming.runtime.tasks.SourceOperatorStreamTaskTest.createTestHarness;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Tests for verifying that the {@link ExternallyInducedSourceReader} can trigger any type of
+ * snapshot.
+ */
+@RunWith(Parameterized.class)
+public class ExternallyInducedSourceOperatorStreamTaskTest extends SourceStreamTaskTestBase {
+    public static final CheckpointStorageLocationReference SAVEPOINT_LOCATION =
+            new CheckpointStorageLocationReference("Savepoint".getBytes());
+    public static final CheckpointStorageLocationReference CHECKPOINT_LOCATION =
+            new CheckpointStorageLocationReference("Checkpoint".getBytes());
+
+    @Parameter(0)
+    public CheckpointOptions checkpointOptions;
+
+    @Parameter(1)
+    public boolean rpcFirst;
+
+    @Parameters
+    public static List<Object[]> provideExternallyInducedParameters() {
+        return Stream.of(
+                        CheckpointOptions.alignedNoTimeout(SAVEPOINT, SAVEPOINT_LOCATION),
+                        CheckpointOptions.alignedNoTimeout(SAVEPOINT_TERMINATE, SAVEPOINT_LOCATION),
+                        CheckpointOptions.alignedNoTimeout(SAVEPOINT_SUSPEND, SAVEPOINT_LOCATION),
+                        CheckpointOptions.alignedNoTimeout(
+                                CheckpointType.CHECKPOINT, CHECKPOINT_LOCATION),
+                        CheckpointOptions.alignedWithTimeout(CHECKPOINT_LOCATION, 123L),
+                        CheckpointOptions.unaligned(CHECKPOINT_LOCATION),
+                        CheckpointOptions.notExactlyOnce(
+                                CheckpointType.CHECKPOINT, CHECKPOINT_LOCATION))
+                .flatMap(
+                        options ->
+                                Stream.of(
+                                        new Object[] {options, true},
+                                        new Object[] {options, false}))
+                .collect(Collectors.toList());
+    }
+
+    @Test
+    public void testExternallyInducedSource() throws Exception {
+        final int numEventsBeforeCheckpoint = 10;
+        final int totalNumEvents = 20;
+        TestingExternallyInducedSourceReader testingReader =
+                new TestingExternallyInducedSourceReader(numEventsBeforeCheckpoint, totalNumEvents);
+        try (StreamTaskMailboxTestHarness<Integer> testHarness =
+                createTestHarness(new TestingExternallyInducedSource(testingReader), 0, null)) {
+            TestingExternallyInducedSourceReader runtimeTestingReader =
+                    (TestingExternallyInducedSourceReader)
+                            ((SourceOperator) testHarness.getStreamTask().mainOperator)
+                                    .getSourceReader();
+
+            CheckpointMetaData checkpointMetaData =
+                    new CheckpointMetaData(TestingExternallyInducedSourceReader.CHECKPOINT_ID, 2);
+            if (rpcFirst) {
+                testHarness.streamTask.triggerCheckpointAsync(
+                        checkpointMetaData, checkpointOptions);
+                testHarness.processAll();
+            } else {
+                do {
+                    testHarness.processSingleStep();
+                } while (!runtimeTestingReader.shouldTriggerCheckpoint().isPresent());
+                // stream task should block when trigger received but no RPC
+                assertFalse(testHarness.streamTask.inputProcessor.isAvailable());
+                CompletableFuture<Boolean> triggerCheckpointAsync =
+                        testHarness.streamTask.triggerCheckpointAsync(
+                                checkpointMetaData, checkpointOptions);
+                // process mails until checkpoint has been processed
+                while (!triggerCheckpointAsync.isDone()) {
+                    testHarness.processSingleStep();
+                }
+                // stream task should be unblocked now
+                assertTrue(testHarness.streamTask.inputProcessor.isAvailable());
+                testHarness.processAll();
+            }
+
+            int expectedEvents =
+                    checkpointOptions.getCheckpointType().isSavepoint()
+                                    && checkpointOptions.getCheckpointType().isSynchronous()
+                                    && checkpointOptions.getCheckpointType().shouldDrain()

Review comment:
       That's fine. We unified the behaviour (stopping source before triggering a savepoint) only in 1.15. In 1.14 we still process records while triggering and cancel the job after the savepoint is taken.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org