You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/09/15 16:34:18 UTC

[GitHub] tinkerpop pull request #422: TINKERPOP-1409 Print no result line if empty.re...

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/422

    TINKERPOP-1409 Print no result line if empty.result.indicator is empty string.

    https://issues.apache.org/jira/browse/TINKERPOP-1409
    
    This seems like a better use of the empty string setting than to actually just print an empty string line.
    
    ```text
    gremlin> graph = TinkerGraph.open()
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> graph.close()
    ==>null
    gremlin> graph = TinkerGraph.open()
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> :set empty.result.indicator ""
    gremlin> graph.close()
    gremlin> 
    ```
    
    Pretty small change, but, I didn't CTR this in case someone didn't really like this behavior.  If there are -1s I can just kill this and close the JIRA currently hanging out there as I only kept it open because I saw this dangling issue I wanted to implement.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #422
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

Posted by okram <gi...@git.apache.org>.

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/422
  
    Acctually, I think the parameterization should be `null.result.indicator` as you check `object == null` and thus, its not "empty," but `null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

Posted by okram <gi...@git.apache.org>.

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/422
  
    Cool. VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/422
  
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #422: TINKERPOP-1409 Print no result line if empty.result.in...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/422
  
    I ended up naming it `result.indicator.null` as "result." was the prefix for other similar preferences:
    
    ```text
    gremlin> graph = TinkerGraph.open()
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> graph.close()
    ==>null
    gremlin> :set result.indicator.null nil
    gremlin> graph = TinkerGraph.open()
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> graph.close()
    ==>nil
    gremlin> :set result.indicator.null ""
    gremlin> graph = TinkerGraph.open()
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> graph.close()
    gremlin> 
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #422: TINKERPOP-1409 Print no result line if empty.re...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---