You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/04/30 17:54:12 UTC
[GitHub] [geode] yozaner1324 opened a new pull request #5030: GEODE-8037 - Create BootstrappingService interface.
yozaner1324 opened a new pull request #5030:
URL: https://github.com/apache/geode/pull/5030
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] moleske commented on pull request #5030: GEODE-8037 - Create BootstrappingService interface.
Posted by GitBox <gi...@apache.org>.
moleske commented on pull request #5030:
URL: https://github.com/apache/geode/pull/5030#issuecomment-622032550
I looked at https://issues.apache.org/jira/projects/GEODE/issues/GEODE-8037 and the issue doesn't really explain why this is being added or what it will do (acceptance criteria or something of the like). I know there's the RFC but some details in the Geode Jira would be handy since I can't quite figure out what's going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org