[GitHub] [dolphinscheduler] caishunfeng opened a new issue #7004: [Bug] [MasterServer] master will still work when it lose zk connection

[GitBox <gi...@apache.org>]

caishunfeng opened a new issue #7004:
URL: https://github.com/apache/dolphinscheduler/issues/7004


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   Now when master lose zk connection, it will still find commands and handle processInstance, because the condition `ServerNodeManager.MASTER_SIZE` and `slot` is not changed. So it may happen two masters have the same slot, and 
   
   I found `MasterRegistryClient` addConnectionStateListener when registry:
   `registryClient.addConnectionStateListener(newState -> {
               if (newState == ConnectionState.RECONNECTED || newState == ConnectionState.SUSPENDED) {
                   registryClient.persistEphemeral(localNodePath, "");
               }
           });
   `
   
   ### What you expected to happen
   
   When master lose zk connection, stop processing command until reconnect.
   
   ### How to reproduce
   
   none
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7004: [Bug] [MasterServer] master will still work when it lose zk connection

[GitBox <gi...@apache.org>]

github-actions[bot] commented on issue #7004:
URL: https://github.com/apache/dolphinscheduler/issues/7004#issuecomment-979650229


   Hi:
   * Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lenboo closed issue #7004: [Bug] [MasterServer] master will still work when it lose zk connection

[GitBox <gi...@apache.org>]

lenboo closed issue #7004:
URL: https://github.com/apache/dolphinscheduler/issues/7004


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org