You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/11/08 01:28:15 UTC

[GitHub] [incubator-echarts] pissang opened a new pull request #13563: chore(dts): generate bundled dts distribution

pissang opened a new pull request #13563:
URL: https://github.com/apache/incubator-echarts/pull/13563


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is about adding dts bundle in the npm distribution. 
   
   ### What does this PR do?
   
   #### Generate a clean DTS bundle
   
   It will generate a dts bundle `types/dist/echarts.d.ts` with [rollup-plugin-dts](https://github.com/Swatinem/rollup-plugin-dts/) plugin. And the default type entry will be changed to this file. This bundle can also be used in https://github.com/apache/incubator-echarts-examples for type checking
   
   This change will simplify the types exposed to developers. To avoid inner module having errors when ts version is not compatible.  Like issue #13541
   
   To make sure no more inner module like `ComponentModel`, `ComponentView`, `Grid` will be exposed. This PR also made some changes to the type structure. 
   
   #### Test generated DTS bundle
   
   This PR includes a test case for testing the compatibility of different ts versions. It will test ts versions from `3.5` to the latest( which is 4.0 at the moment this PR is created. Which means the lowest ts version our dts supported is `3.5`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13563: chore(dts): generate bundled dts distribution

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13563:
URL: https://github.com/apache/incubator-echarts/pull/13563#issuecomment-723517621


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #13563: chore(dts): generate bundled dts distribution

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13563:
URL: https://github.com/apache/incubator-echarts/pull/13563


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13563: chore(dts): generate bundled dts distribution

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13563:
URL: https://github.com/apache/incubator-echarts/pull/13563#issuecomment-723534819


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org