You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "tkhurana (via GitHub)" <gi...@apache.org> on 2024/07/02 18:15:06 UTC

Re: [PR] PHOENIX-7287 Leverage bloom filters for multi-key point lookups [phoenix]

tkhurana commented on code in PR #1923:
URL: https://github.com/apache/phoenix/pull/1923#discussion_r1662970076


##########
phoenix-core-client/src/main/java/org/apache/phoenix/filter/SkipScanFilter.java:
##########
@@ -618,7 +632,8 @@ public void readFields(DataInput in) throws IOException {
                 orClause.add(range);
             }
         }
-        this.init(slots, slotSpan, schema, includeMultipleVersions);
+        boolean isPointLookup = in.readBoolean();

Review Comment:
   For backward compatibility we need to handle EOFException because the older clients won't be sending the boolean field



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org