You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/04 20:48:36 UTC
[GitHub] [airflow] ryanahamilton commented on a change in pull request #12811: Collapse the importErrors pane by default
ryanahamilton commented on a change in pull request #12811:
URL: https://github.com/apache/airflow/pull/12811#discussion_r536365656
##########
File path: airflow/www/templates/appbuilder/flash.html
##########
@@ -53,13 +53,13 @@
<div class="panel panel-default">
<div class="panel-heading" id="errorHeading">
<h4 class="panel-title">
- <a id="alerts-accordion-toggle" data-toggle="collapse" data-parent="#accordion" href="#alerts" aria-expanded="false">
+ <a id="alerts-accordion-toggle" data-toggle="collapse" data-parent="#accordion" href="#alerts" aria-expanded="false" class="collapsed">
DAG Import Errors ({{ dag_import_errors|length }})
Review comment:
Since the red error message blocks won't be visible by default anymore, I think it would be good to add some emphasis to the to toggle with color and an icon—something like this:
```suggestion
<span class="text-danger"><span class="material-icons" aria-hidden="true">error</span> DAG Import Errors ({{ dag_import_errors|length }})</span>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org