You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/11/19 22:30:44 UTC

[jclouds-labs-openstack] Refactored QueueApi and pushed name param up to MarconiApi. (#52)

https://issues.apache.org/jira/browse/JCLOUDS-340
You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack marconi-refactor-queue-api

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/52

-- Commit Summary --

  * Refactored QueueApi and pushed name param up to MarconiApi.

-- File Changes --

    M openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/MarconiApi.java (7)
    M openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/features/QueueApi.java (41)
    M openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/MessageApiLiveTest.java (8)
    M openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiLiveTest.java (32)
    M openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/QueueApiMockTest.java (32)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/52.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/52.diff

Re: [jclouds-labs-openstack] Refactored QueueApi and pushed name param up to MarconiApi. (#52)

Posted by Everett Toews <no...@github.com>.

Invalid statement. List messages couldn't even be coded in order to be tested.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/52#issuecomment-28860814

Re: [jclouds-labs-openstack] Refactored QueueApi and pushed name param up to MarconiApi. (#52)

Posted by Everett Toews <no...@github.com>.

Reverted. Turns out you can't implement list messages with this refactoring.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/52#issuecomment-28844880

Re: [jclouds-labs-openstack] Refactored QueueApi and pushed name param up to MarconiApi. (#52)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-openstack-pull-requests #100](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/100/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/52#issuecomment-28838103

Re: [jclouds-labs-openstack] Refactored QueueApi and pushed name param up to MarconiApi. (#52)

Posted by Andrew Phillips <no...@github.com>.

> Reverted. Turns out you can't implement list messages with this refactoring.

Would it have been feasible to have a test case for "list messages" whose failure could have caught this? Or is that (quite possibly!) an invalid statement to make in this case..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/52#issuecomment-28847108

Re: [jclouds-labs-openstack] Refactored QueueApi and pushed name param up to MarconiApi. (#52)

Posted by Andrew Phillips <no...@github.com>.

> List messages couldn't even be coded in order to be tested.

Thanks for explaining!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/52#issuecomment-28864181

Re: [jclouds-labs-openstack] Refactored QueueApi and pushed name param up to MarconiApi. (#52)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-openstack #637](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/637/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/52#issuecomment-28838545