You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2026/03/01 14:40:30 UTC
[PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
zclllyybb opened a new pull request, #60934:
URL: https://github.com/apache/doris/pull/60934
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When lazy materialization encounters a slot that went through an eliminated UNION ALL branch, the slot may lack originalColumn metadata even though the base slot has it. This causes "field name is invalid" errors during materialization RPC.
Fix by copying originalColumn from baseSlot to the target slot when the target slot is missing it but the baseSlot has it.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60934:
URL: https://github.com/apache/doris/pull/60934#issuecomment-3980360005
# BE UT Coverage Report
Increment line coverage `0.00% (0/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/54e7e7e4c6409fdf9fc157e4d183ec0089701b88_54e7e7e4c6409fdf9fc157e4d183ec0089701b88/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/54e7e7e4c6409fdf9fc157e4d183ec0089701b88_54e7e7e4c6409fdf9fc157e4d183ec0089701b88/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.57% (19628/37337) |
| Line Coverage | 36.19% (183249/506362) |
| Region Coverage | 32.48% (142147/437582) |
| Branch Coverage | 33.44% (61662/184369) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60934:
URL: https://github.com/apache/doris/pull/60934#issuecomment-3980116476
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #60934:
URL: https://github.com/apache/doris/pull/60934#issuecomment-3980116671
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60934:
URL: https://github.com/apache/doris/pull/60934#issuecomment-3980290545
<details>
<summary>TPC-DS: <b>Total hot run time: 183994 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 54e7e7e4c6409fdf9fc157e4d183ec0089701b88, data reload: false
query5 4958 639 506 506
query6 333 223 229 223
query7 4224 477 275 275
query8 345 251 242 242
query9 8801 2779 2719 2719
query10 542 382 333 333
query11 16940 17510 17222 17222
query12 214 135 125 125
query13 1384 493 383 383
query14 8200 3401 3128 3128
query14_1 2931 2942 2940 2940
query15 211 206 182 182
query16 1018 467 493 467
query17 1389 759 666 666
query18 3041 479 369 369
query19 208 215 182 182
query20 143 134 138 134
query21 217 147 125 125
query22 5491 4892 4820 4820
query23 17189 16890 16571 16571
query23_1 16782 16750 16691 16691
query24 7384 1645 1272 1272
query24_1 1262 1245 1227 1227
query25 567 480 428 428
query26 1242 267 204 204
query27 2712 480 285 285
query28 4422 1857 1863 1857
query29 792 550 463 463
query30 304 246 213 213
query31 861 727 639 639
query32 81 74 72 72
query33 521 340 281 281
query34 910 920 563 563
query35 633 685 610 610
query36 1097 1116 1000 1000
query37 134 100 89 89
query38 2980 2902 2926 2902
query39 886 882 841 841
query39_1 852 819 817 817
query40 228 148 136 136
query41 65 64 58 58
query42 104 102 103 102
query43 381 391 351 351
query44
query45 194 194 184 184
query46 884 993 603 603
query47 2090 2131 2041 2041
query48 314 319 228 228
query49 648 475 393 393
query50 684 286 219 219
query51 4074 4055 4091 4055
query52 108 106 99 99
query53 290 348 281 281
query54 309 273 246 246
query55 93 88 82 82
query56 309 351 302 302
query57 1350 1341 1287 1287
query58 281 276 273 273
query59 2544 2775 2590 2590
query60 341 332 321 321
query61 146 149 143 143
query62 644 610 543 543
query63 314 273 269 269
query64 4814 1257 960 960
query65
query66 1384 471 362 362
query67 16282 16312 16207 16207
query68
query69 387 321 286 286
query70 990 998 939 939
query71 346 304 301 301
query72 2878 2620 2365 2365
query73 541 561 326 326
query74 10035 9941 9803 9803
query75 2884 2756 2457 2457
query76 2303 1025 674 674
query77 358 384 311 311
query78 11208 11331 10697 10697
query79 2365 830 598 598
query80 1755 632 562 562
query81 560 289 251 251
query82 1021 146 114 114
query83 341 270 245 245
query84 249 113 89 89
query85 892 474 486 474
query86 413 325 327 325
query87 3125 3062 3040 3040
query88 3573 2663 2635 2635
query89 427 374 356 356
query90 2008 174 169 169
query91 157 154 132 132
query92 77 77 71 71
query93 1046 864 524 524
query94 632 334 289 289
query95 571 403 318 318
query96 647 516 237 237
query97 2496 2458 2417 2417
query98 236 215 219 215
query99 1020 1001 916 916
Total cold run time: 257906 ms
Total hot run time: 183994 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb closed pull request #60934: [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN
URL: https://github.com/apache/doris/pull/60934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60934:
URL: https://github.com/apache/doris/pull/60934#issuecomment-3980256450
<details>
<summary>TPC-H: <b>Total hot run time: 28563 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 54e7e7e4c6409fdf9fc157e4d183ec0089701b88, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17663 4419 4312 4312
q2 q3 10663 754 516 516
q4 4671 352 253 253
q5 7547 1187 1020 1020
q6 177 177 148 148
q7 764 840 657 657
q8 9590 1434 1284 1284
q9 4798 4750 4726 4726
q10 6834 1869 1628 1628
q11 453 254 228 228
q12 738 560 471 471
q13 17803 4195 3380 3380
q14 224 231 212 212
q15 975 792 800 792
q16 731 719 661 661
q17 704 878 445 445
q18 5965 5394 5238 5238
q19 1301 961 622 622
q20 491 493 383 383
q21 4528 1813 1347 1347
q22 331 279 240 240
Total cold run time: 96951 ms
Total hot run time: 28563 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4435 4334 4356 4334
q2 q3 1754 2188 1704 1704
q4 833 1153 760 760
q5 4007 4310 4321 4310
q6 182 174 144 144
q7 1736 1601 1477 1477
q8 2421 2618 2482 2482
q9 7160 7762 7408 7408
q10 2669 2823 2402 2402
q11 504 428 414 414
q12 496 582 484 484
q13 4058 4541 3656 3656
q14 289 343 268 268
q15 826 820 829 820
q16 712 745 717 717
q17 1207 1535 1273 1273
q18 7166 6892 6502 6502
q19 876 876 937 876
q20 2107 2194 2010 2010
q21 3985 3447 3453 3447
q22 453 431 387 387
Total cold run time: 47876 ms
Total hot run time: 45875 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lazy-materialize) preserve originalColumn for slots through eliminated UNION ALL in LazyMaterializeTopN [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60934:
URL: https://github.com/apache/doris/pull/60934#issuecomment-3982251925
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60934_54e7e7e4c6409fdf9fc157e4d183ec0089701b88_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60934_54e7e7e4c6409fdf9fc157e4d183ec0089701b88_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.45% (26123/36559) |
| Line Coverage | 54.26% (273919/504809) |
| Region Coverage | 51.55% (227718/441719) |
| Branch Coverage | 52.93% (97885/184933) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org