You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/10 06:00:49 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#4687: Refactor orchestration phase 1.1.1
kimmking opened a new pull request #4687: Refactor orchestration phase 1.1.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4687
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
- remove Sets&Maps referred from guava
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4687:
Refactor orchestration phase 1.1.1
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4687: Refactor orchestration phase 1.1.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4687#issuecomment-596925907
## Pull Request Test Coverage Report for [Build 2055](https://coveralls.io/builds/29241333)
* **7** of **9** **(77.78%)** changed or added relevant lines in **4** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.08%**) to **59.107%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/29241333/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L95) | 1 | 3 | 33.33%
<!-- | **Total:** | **7** | **9** | **77.78%** | -->
| Totals | [](https://coveralls.io/builds/29241333) |
| :-- | --: |
| Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.08% |
| Covered Lines: | 12114 |
| Relevant Lines: | 20495 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4687: Refactor orchestration phase 1.1.1
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4687: Refactor orchestration phase 1.1.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4687#issuecomment-596925907
## Pull Request Test Coverage Report for [Build 2060](https://coveralls.io/builds/29245895)
* **6** of **8** **(75.0%)** changed or added relevant lines in **3** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.004%**) to **59.032%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/29245895/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L95) | 2 | 4 | 50.0%
<!-- | **Total:** | **6** | **8** | **75.0%** | -->
| Totals | [](https://coveralls.io/builds/29245895) |
| :-- | --: |
| Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.004% |
| Covered Lines: | 12098 |
| Relevant Lines: | 20494 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4687:
Refactor orchestration phase 1.1.1
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4687: Refactor orchestration phase 1.1.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4687#issuecomment-596981551
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=h1) Report
> Merging [#4687](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6fcd9b4bc8d4747d85d28bb948c0d5fc0cec8ce0?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4687 +/- ##
============================================
+ Coverage 55.48% 55.48% +<.01%
Complexity 426 426
============================================
Files 1134 1135 +1
Lines 20492 20495 +3
Branches 3799 3799
============================================
+ Hits 11369 11372 +3
Misses 8409 8409
Partials 714 714
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `59.45% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ngsphere/orchestration/internal/util/MapUtils.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvdXRpbC9NYXBVdGlscy5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../registry/config/service/ConfigurationService.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvY29uZmlnL3NlcnZpY2UvQ29uZmlndXJhdGlvblNlcnZpY2UuamF2YQ==) | `76% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...egistry/config/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvY29uZmlnL2xpc3RlbmVyL1NjaGVtYUNoYW5nZWRMaXN0ZW5lci5qYXZh) | `71.42% <33.33%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=footer). Last update [6fcd9b4...d2710b0](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4687:
Refactor orchestration phase 1.1.1
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4687: Refactor orchestration phase 1.1.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4687: Refactor orchestration phase 1.1.1
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4687: Refactor orchestration phase 1.1.1
URL: https://github.com/apache/incubator-shardingsphere/pull/4687#issuecomment-596925907
## Pull Request Test Coverage Report for [Build 10156](https://coveralls.io/builds/29244146)
* **7** of **9** **(77.78%)** changed or added relevant lines in **4** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.001%**) to **59.029%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/29244146/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L95) | 1 | 3 | 33.33%
<!-- | **Total:** | **7** | **9** | **77.78%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29244146/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29244146) |
| :-- | --: |
| Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.001% |
| Covered Lines: | 12098 |
| Relevant Lines: | 20495 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services