You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 21:21:39 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25884: The old breeze video and related assets are removed
potiuk opened a new pull request, #25884:
URL: https://github.com/apache/airflow/pull/25884
The video and related assets are not valid in most cases any more.
We discussed re-recording Breeze videe after we complete Python
conversion.
This PR was extracted out of #25678 as it outgrew it's initial scope
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25884: The old breeze video and related assets are removed
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25884:
URL: https://github.com/apache/airflow/pull/25884#discussion_r951976690
##########
BREEZE.rst:
##########
@@ -806,32 +718,6 @@ through ``breeze testing docker-compose-tests`` command.
The docker-compose tests are in ``docker-tests/`` folder in the main repo.
-Running Kubernetes tests
-........................
-
-Breeze helps with running Kubernetes tests in the same environment/way as CI tests are run.
-Breeze helps to setup KinD cluster for testing, setting up virtualenv and downloads the right tools
-automatically to run the tests.
-
-You can:
-
-* Manage KinD Kubernetes cluster and deploy Airflow to KinD cluster ``./breeze-legacy kind-cluster`` commands
-* Run Kubernetes tests specified with ``./breeze-legacy kind-cluster tests`` command
-* Enter the interactive kubernetes test environment with ``./breeze-legacy kind-cluster shell`` command
-
-This is described in detail in `Testing Kubernetes <TESTING.rst#running-tests-with-kubernetes>`_.
Review Comment:
Yep. This is very temporary and it is going to be replaced by #25678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25884: The old breeze video and related assets are removed
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #25884:
URL: https://github.com/apache/airflow/pull/25884#discussion_r951975690
##########
BREEZE.rst:
##########
@@ -806,32 +718,6 @@ through ``breeze testing docker-compose-tests`` command.
The docker-compose tests are in ``docker-tests/`` folder in the main repo.
-Running Kubernetes tests
-........................
-
-Breeze helps with running Kubernetes tests in the same environment/way as CI tests are run.
-Breeze helps to setup KinD cluster for testing, setting up virtualenv and downloads the right tools
-automatically to run the tests.
-
-You can:
-
-* Manage KinD Kubernetes cluster and deploy Airflow to KinD cluster ``./breeze-legacy kind-cluster`` commands
-* Run Kubernetes tests specified with ``./breeze-legacy kind-cluster tests`` command
-* Enter the interactive kubernetes test environment with ``./breeze-legacy kind-cluster shell`` command
-
-This is described in detail in `Testing Kubernetes <TESTING.rst#running-tests-with-kubernetes>`_.
Review Comment:
Did you mean to remove this section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25884: The old breeze video and related assets are removed
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25884:
URL: https://github.com/apache/airflow/pull/25884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25884: The old breeze video and related assets are removed
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25884:
URL: https://github.com/apache/airflow/pull/25884#issuecomment-1223087867
Removing a lot :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25884: The old breeze video and related assets are removed
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25884:
URL: https://github.com/apache/airflow/pull/25884#issuecomment-1223081938
cc: @rossturk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25884: The old breeze video and related assets are removed
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25884:
URL: https://github.com/apache/airflow/pull/25884#issuecomment-1223263069
Getting close to remove all old-breeze stuff :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org