[jira] [Commented] (ARROW-5991) [C++] Does DictionaryBuilder need to be a subclass of ArrayBuilder?

["Benjamin Kietzman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892937#comment-16892937 ] 

Benjamin Kietzman commented on ARROW-5991:
------------------------------------------

Another possibility is to let DictionaryBuilder inherit AdaptiveIntBuilder

> [C++] Does DictionaryBuilder<T> need to be a subclass of ArrayBuilder? 
> -----------------------------------------------------------------------
>
>                 Key: ARROW-5991
>                 URL: https://issues.apache.org/jira/browse/ARROW-5991
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Major
>
> I note that {{DictionaryBuilder<T>}} is book-keeping properties both in {{values_builder_}} as well as itself, such as {{length_}} and {{null_count_}}. 
> There are two possibilities:
> * DictionaryBuilder need not be a subclass of ArrayBuilder
> * A common abstract base for builders could be defined to allow properties like {{length_}} to be forwarded by virtual overrides



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)