You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/03/18 04:45:50 UTC

[GitHub] [calcite] DonnyZone commented on a change in pull request #1761: [CALCITE-3737][CALCITE-3780] Implement HOP and SESSION table functions

DonnyZone commented on a change in pull request #1761: [CALCITE-3737][CALCITE-3780] Implement HOP and SESSION table functions
URL: https://github.com/apache/calcite/pull/1761#discussion_r394104378
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
 ##########
 @@ -2273,8 +2275,14 @@ public void unparse(
   /** DESCRIPTOR(column_name, ...). */
   public static final SqlOperator DESCRIPTOR = new SqlDescriptorOperator();
 
-  /** TUMBLE as a table-value function. */
-  public static final SqlFunction TUMBLE_TVF = new SqlWindowTableFunction(SqlKind.TUMBLE.name());
+  /** TUMBLE as a table function. */
+  public static final SqlFunction TUMBLE_TVF = new SqlTumbleTableFunction();
 
 Review comment:
   Just of curious, is the "TVF" a commonly-used abbreviation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services