You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/15 00:57:07 UTC
Review Request 38375: Fixed process::collect and process::await to do
discard propagation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38375/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-3426
https://issues.apache.org/jira/browse/MESOS-3426
Repository: mesos
Description
-------
Fixed process::collect and process::await to do discard propagation.
Diffs
-----
3rdparty/libprocess/Makefile.am 6361ac6485760fdeed87a2c049d6431783989462
3rdparty/libprocess/include/process/collect.hpp d07b6860a5b5cbed910b2e9e2ab2429bd70a3999
3rdparty/libprocess/src/tests/CMakeLists.txt b61ca1e5be2054c1156205c62a1e8311a575bfa5
3rdparty/libprocess/src/tests/collect_tests.cpp PRE-CREATION
3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6
Diff: https://reviews.apache.org/r/38375/diff/
Testing
-------
Pulled out collect_tests.cpp and added a 'DiscardPropagation' test for both collect and await.
Thanks,
Ben Mahler
Re: Review Request 38375: Fixed process::collect and process::await
to do discard propagation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38375/#review98944
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38375/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3426
> https://issues.apache.org/jira/browse/MESOS-3426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed process::collect and process::await to do discard propagation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 6361ac6485760fdeed87a2c049d6431783989462
> 3rdparty/libprocess/include/process/collect.hpp d07b6860a5b5cbed910b2e9e2ab2429bd70a3999
> 3rdparty/libprocess/src/tests/CMakeLists.txt b61ca1e5be2054c1156205c62a1e8311a575bfa5
> 3rdparty/libprocess/src/tests/collect_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6
>
> Diff: https://reviews.apache.org/r/38375/diff/
>
>
> Testing
> -------
>
> Pulled out collect_tests.cpp and added a 'DiscardPropagation' test for both collect and await.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38375: Fixed process::collect and process::await
to do discard propagation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38375/#review99008
-----------------------------------------------------------
Bad patch!
Reviews applied: [38375]
Failed command: ./support/apply-review.sh -n -r 38375
Error:
2015-09-15 10:27:13 URL:https://reviews.apache.org/r/38375/diff/raw/ [15405/15405] -> "38375.patch" [1]
error: patch failed: 3rdparty/libprocess/Makefile.am:137
error: 3rdparty/libprocess/Makefile.am: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/collect.hpp:93
error: 3rdparty/libprocess/include/process/collect.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/tests/CMakeLists.txt:20
error: 3rdparty/libprocess/src/tests/CMakeLists.txt: patch does not apply
error: 3rdparty/libprocess/src/tests/collect_tests.cpp: already exists in index
error: patch failed: 3rdparty/libprocess/src/tests/process_tests.cpp:27
error: 3rdparty/libprocess/src/tests/process_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38375/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3426
> https://issues.apache.org/jira/browse/MESOS-3426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed process::collect and process::await to do discard propagation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 6361ac6485760fdeed87a2c049d6431783989462
> 3rdparty/libprocess/include/process/collect.hpp d07b6860a5b5cbed910b2e9e2ab2429bd70a3999
> 3rdparty/libprocess/src/tests/CMakeLists.txt b61ca1e5be2054c1156205c62a1e8311a575bfa5
> 3rdparty/libprocess/src/tests/collect_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6
>
> Diff: https://reviews.apache.org/r/38375/diff/
>
>
> Testing
> -------
>
> Pulled out collect_tests.cpp and added a 'DiscardPropagation' test for both collect and await.
>
>
> Thanks,
>
> Ben Mahler
>
>