You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/09 22:34:57 UTC
[GitHub] [fineract] vorburger opened a new pull request #873: bump guava from 28.1-jre to 29.0-jre
vorburger opened a new pull request #873:
URL: https://github.com/apache/fineract/pull/873
Bumps [guava](https://github.com/google/guava) from 28.1-jre to 29.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #873: bump guava from 28.1-jre to 29.0-jre
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #873:
URL: https://github.com/apache/fineract/pull/873#issuecomment-626323182
Contrary to the some of the other PRs I've just merged, I'd like to be much more careful with this one...
@ptuomola and others reading along here, do you think this upgrade is "safe" ?
Is this affecting build time only, or runtime, or both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #873: bump guava from 28.1-jre to 29.0-jre
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #873:
URL: https://github.com/apache/fineract/pull/873#issuecomment-628383843
@vorburger Unfortunately I'm not an expert on Guava... but looking at the dependencies:
- The only reference in Fineract source to Guava that I was able to find is in some comments in org.apache.fineract.infrastructure.bulkimport.populator, and everything seems to compile OK even if I remove the Guava dependency from dependencies.gradle. Do we even use this in Fineract?
- checkstyle is already expecting 0.29
- If we upgrade Mustache to latest version (0.9.6), it no longer seems to depend on Guava
So after that, it's only Swagger and ActiveMQ that are expecting Guava 27 / 28 but would get 29. Looking at the changelog I did not see anything that made me worried, but of course you never know...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #873: bump guava from 28.1-jre to 29.0-jre
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #873:
URL: https://github.com/apache/fineract/pull/873#issuecomment-631354797
#913 is now merged. Should we therefore close this and not upgrade Guava?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #873: bump guava from 28.1-jre to 29.0-jre
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #873:
URL: https://github.com/apache/fineract/pull/873#issuecomment-631138935
@ptuomola you raise (as always, thanks!) some excellent points above....
How about #913 instead of this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #873: bump guava from 28.1-jre to 29.0-jre
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #873:
URL: https://github.com/apache/fineract/pull/873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org