You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/17 02:45:48 UTC

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1967: Remove combined-server config in dolphinscheduler-daemon.sh file

codecov-io commented on issue #1967: Remove combined-server config in dolphinscheduler-daemon.sh file
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1967#issuecomment-586795214
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967?src=pr&el=h1) Report
   > Merging [#1967](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/5ccebbf5f8f17720d038a319d91a4bfda2825789?src=pr&el=desc) will **increase** coverage by `3.14%`.
   > The diff coverage is `16.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #1967      +/-   ##
   ============================================
   + Coverage     27.14%   30.28%   +3.14%     
   + Complexity     1383     1367      -16     
   ============================================
     Files           312      294      -18     
     Lines         16680    14999    -1681     
     Branches       2056     1806     -250     
   ============================================
   + Hits           4528     4543      +15     
   + Misses        11672    10006    -1666     
   + Partials        480      450      -30
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nscheduler/dao/datasource/SQLServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvU1FMU2VydmVyRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...hinscheduler/dao/datasource/PostgreDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvUG9zdGdyZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...phinscheduler/dao/datasource/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvT3JhY2xlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...olphinscheduler/dao/datasource/HiveDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvSGl2ZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...hinscheduler/dao/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvRGF0YVNvdXJjZUZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...e/dolphinscheduler/common/utils/Preconditions.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1ByZWNvbmRpdGlvbnMuamF2YQ==) | `0% <ø> (-63.16%)` | `0 <0> (-20)` | |
   | [...scheduler/dao/datasource/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ2xpY2tIb3VzZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `5.12% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
   | [...che/dolphinscheduler/server/zk/ZKWorkerClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLV29ya2VyQ2xpZW50LmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [56 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967?src=pr&el=footer). Last update [5ccebbf...f959c8e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1967?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services