You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/03/23 02:10:30 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1342: Implement the new encoding with 64bit size and expire time in milliseconds

git-hulk commented on code in PR #1342:
URL: https://github.com/apache/incubator-kvrocks/pull/1342#discussion_r1144279452


##########
src/storage/compact_filter.cc:
##########
@@ -92,7 +92,7 @@ bool SubKeyFilter::IsMetadataExpired(const InternalKey &ikey, const Metadata &me
   //
   // `Util::GetTimeStamp() - 300` means extending 5 minutes for expired items,

Review Comment:
   ```suggestion
     // `Util::GetTimeStampMS() - 300000` means extending 5 minutes for expired items,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org