You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/04/29 00:21:48 UTC

Review Request 58867: SENTRY-1734 Create/Alter/Drop database/table should check corresponding property before drop priv...

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58867/
-----------------------------------------------------------

Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and Vamsee Yarlagadda.


Bugs: SENTRY-1734
    https://issues.apache.org/jira/browse/SENTRY-1734


Repository: sentry


Description
-------

SENTRY-1734 Create/Alter/Drop database/table should check corresponding property before drop priv...


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java ca4487f279f435c45be9ded7bd00086f2bbd9b02 


Diff: https://reviews.apache.org/r/58867/diff/1/


Testing
-------


Thanks,

Alexander Kolbasov


Re: Review Request 58867: SENTRY-1734 Create/Alter/Drop database/table should check corresponding property before drop priv...

Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58867/#review173455
-----------------------------------------------------------


Fix it, then Ship it!





sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 527 (patched)
<https://reviews.apache.org/r/58867/#comment246434>

    Do we need to file a jira to track it?


- Hao Hao


On April 29, 2017, 12:21 a.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58867/
> -----------------------------------------------------------
> 
> (Updated April 29, 2017, 12:21 a.m.)
> 
> 
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1734
>     https://issues.apache.org/jira/browse/SENTRY-1734
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1734 Create/Alter/Drop database/table should check corresponding property before drop priv...
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java ca4487f279f435c45be9ded7bd00086f2bbd9b02 
> 
> 
> Diff: https://reviews.apache.org/r/58867/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>