[jira] Commented: (CAMEL-3741) Add new options to camel-jt400

["Willem Jiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001265#comment-13001265 ] 

Willem Jiang commented on CAMEL-3741:
-------------------------------------

Hi Luis,

Thanks for your contribution, I just applied you patch by fixing some check style issue and changing to use slf4j logger.
Here is one question for the Jt400PgmProducer that you new add.
When the pgmCall failed, do we need to throw an exception to fire the camel error handler?
I don't think it's a good idea that just print the message out.
 
{code}

        boolean result = pgmCall.run();

        if (LOG.isTraceEnabled()) {
            LOG.trace("Executed PGM '" + commandStr + "' in host '" + iSeries.getSystemName() + "'. Success?"
                     + result);
        }

        if (result) {
            handlePGMOutput(exchange, pgmCall, parameterList);
        } else {
            // TODO Do we need to throw an exception here
            handleMessages(pgmCall);
        }
{code}

Willem


> Add new options to camel-jt400
> ------------------------------
>
>                 Key: CAMEL-3741
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3741
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Luis Santos
>            Assignee: Willem Jiang
>              Labels: component, features, jt400
>             Fix For: 2.8.0, 3.0.0
>
>         Attachments: patch_camel-jt400_pgm_call_2.6.0.txt, patch_camel-jt400_pgm_call_trunk.txt
>
>
> I've added a new feature to the existing camel-jt400 component to enable the remote program call of iSeries programs.
> This implementation was successfully tested with the jt400 library already included in the pom dependencies against real systems running the version V5R4 od the OS.
> The usage of this new feature is exactly the same of the DATQ feature except the path now has to point to a PGM file and there are 2 mandatory arguments: outputFieldsIdx and fieldsLength.
> *outputFieldsIdx* register which parameters of the program will be INPUT/OUTPUT (as oposed of only INPUT)
> *fieldsLength*: registers the mandatory parameters length
> Sample usage in a route (included in the test case)
> from("direct:a").to("jt400://user:password@host/QSYS.LIB/library.LIB/program.pgm?outputFieldsIdx=1,2&fieldsLength=4,512,2").to("mock:a");
> I'm including a patch to both 2.6.0 and trunk as of today.
> Please let me know if something is not OK.. I'm more than happy to make the adjustments.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira