[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2044: Fixed class cast exception when customzing the URLDisplayer

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2044: Fixed class cast exception when customzing the URLDisplayer
URL: https://github.com/apache/netbeans/pull/2044#discussion_r397444939
 
 

 ##########
 File path: platform/openide.awt/src/org/openide/awt/HtmlBrowser.java
 ##########
 @@ -965,6 +965,14 @@ public static URLDisplayer getDefault() {
         public void showURLExternal(URL u) {
             showURL(u);
         }
+        
+        /**
+         * resets the caches used
+         * If the default browser is changed this clears the instantiated objects for the old one
+         */
+        public void clearCache(){
+            
+        }
 
 Review comment:
   I think you covered everything. I think the only thing missing is `org.netbeans.core` needs to update its dependency on `org.openide.awt` to the newly set version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists