You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/22 12:30:47 UTC
[GitHub] [pulsar-manager] sannadi99 opened a new pull request #338: Adding mysql connector dependencies
sannadi99 opened a new pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338
Fixes #Unable to find mysql jdbc driver dependency
Master Issue: #Missing mysql jdbc connector dependency
### Motivation
When i tried using mysql custom database for pulsar manager i found a bug (unable to find jdbc driver). I fixed it in my local and tested so trying to add the same dependency to apache/pulsar-manager
### Modifications
I changed build.gradle and added mysql dependency
I changed gradle.properties to add version to it
### Verifying this change
I tested in my local and it worked. I am able to connect to my local sql server and use it in pulsar manager running locally through cloned code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tuteng commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
tuteng commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697193787
@sannadi99 I will add support for MySQL under this repository https://github.com/streamnative/pulsar-manager, Thank you for your contribution, Are you interested in sending this pr to the repository https://github.com/streamnative/pulsar-manager, I will update the document and docker image later https://hub.docker.com/r/streamnative/pulsar-manager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tuteng commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
tuteng commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-701728825
This has been added here https://github.com/streamnative/pulsar-manager/issues/164, we can close it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] sannadi99 commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
sannadi99 commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-696921416
@eolivelli If my approach is correct please help me with this PR approval or if it is not a correct way can you help me on using custom mysql database for pulsar manager? I mean any docs or examples will be fine. Lot of things depends on this to proceed further on my project requirement. Thanks in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] rvashishth commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
rvashishth commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697154042
isn't MariaDB compatible with MySql implementation, it would be nice to use the MySQL with pulsar-manager without maintaining a cloned source?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tuteng closed pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
tuteng closed pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] sannadi99 commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
sannadi99 commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-696713595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] sannadi99 commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
sannadi99 commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-696713595
@sannadi99 did you run the tests using MySQL ?
I am not sure it works.
@eolivelli Yes i did and it worked for me in my local (mysql server and pulsar manager running in local)
Probably it will work because HerdDB is compatible with MySQL dialect.
Yes you are right might be wit this https://github.com/apache/pulsar-manager/blob/c300c94c8affe9be7ca66b64718f9e2629bd1281/src/main/resources/application.properties#L74
And also for local testing i used datasource properties directly in application.properties like this.
spring.datasource.driver-class-name=com.mysql.jdbc.Driver
spring.datasource.url=jdbc:mysql://localhost:3306/pulsar_manager
spring.datasource.schema=classpath:/META-INF/sql/mysql-schema.sql
Then it worked able to see all intial setup tables in local mysql server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] eolivelli commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697188395
@tuteng is right, I was going to write the same comment.
We dropped MySQL support during the donation by StreamNative and moved to HerdDB + PostGRE, that are Apache License friend.
You could try out HerdDB, feel free to ask on HerdDB github repository for any guidance (I am one of the maintainers), we also have a slack channel hosted inside Apache BookKeeper Slack.
https://bookkeeper.apache.org/community/slack/
https://github.com/diennea/herddb/wiki/Installing-and-running-HerdDB
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] eolivelli commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-696690803
@sannadi99 did you run the tests using MySQL ?
I am not sure it works.
Probably it will work because HerdDB is compatible with MySQL dialect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] sijie commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697201162
@sannadi99 Give the ASF policy, we are not able to host any official releases with MySQL because the license that MySQL is using is not compatible with ASF policy. However, as what @tuteng commented, we are happy to maintain the MySQL integration in our fork - https://github.com/streamnative/pulsar-manager to make things simpler at your side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] sannadi99 commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
sannadi99 commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697335320
Hello @tuteng , @eolivelli and @sijie Yeah i understood why you were unable to support MySql from apache/pulsar As you guys suggested i can move my changes to https://github.com/streamnative/pulsar-manager repo. But can we get these into https://hub.docker.com/r/streamnative/pulsar-manager as soon as possible. We will make changes to pull pulsar manager from stream native and use Mysql from there. This will make our work a bit simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tuteng commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
tuteng commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697066906
I'm sorry for the confusion. When we donated the project to apache, because of the conflict between the license of MySQL and the license of apache, we deleted the dependence of MySQL, so we may not be able to merge this pr. If users want to use the Mysql database, they need to build from source code. However, we should explain this in the document. @sannadi99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] sijie commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697564782
@sannadi99 We can do that. There is no problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] eolivelli commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-696690803
@sannadi99 did you run the tests using MySQL ?
I am not sure it works.
Probably it will work because HerdDB is compatible with MySQL dialect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tuteng commented on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
tuteng commented on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697066906
I'm sorry for the confusion. When we donated the project to apache, because of the conflict between the license of MySQL and the license of apache, we deleted the dependence of MySQL, so we may not be able to merge this pr. If users want to use the Mysql database, they need to build from source code. However, we should explain this in the document. @sannadi99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tuteng edited a comment on pull request #338: Adding mysql connector dependencies
Posted by GitBox <gi...@apache.org>.
tuteng edited a comment on pull request #338:
URL: https://github.com/apache/pulsar-manager/pull/338#issuecomment-697193787
@sannadi99 I will add support for MySQL under this repository https://github.com/streamnative/pulsar-manager, Thank you for your contribution, Are you interested in sending this pr to the repository https://github.com/streamnative/pulsar-manager, I will update the document and docker image later https://hub.docker.com/r/streamnative/pulsar-manager.
This is a task list https://github.com/streamnative/pulsar-manager/issues/164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org