You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2025/09/18 02:52:49 UTC
[PR] Enforce one global executor [airflow]
o-nikolas opened a new pull request, #55816:
URL: https://github.com/apache/airflow/pull/55816
There are various processes in Airflow that are not yet team-ified and that rely on executors (serving logs, callback handling) so for now, enforce that at least one global executor is present to be used for such things. This can be revisited and relaxed at a future time.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce one global executor [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #55816:
URL: https://github.com/apache/airflow/pull/55816#discussion_r2360929289
##########
airflow-core/tests/unit/executors/test_executor_loader.py:
##########
@@ -560,3 +549,22 @@ def test_single_global_team_configurations_work(self, executor_config, expected_
with conf_vars({("core", "executor"): executor_config}):
configs = executor_loader.ExecutorLoader._get_team_executor_configs()
assert configs == expected_configs
+
+ @pytest.mark.parametrize(
+ "executor_config",
+ [
+ "team1=CeleryExecutor",
+ "team1=CeleryExecutor;team2=LocalExecutor",
+ "team1=CeleryExecutor;team2=LocalExecutor;team3=KubernetesExecutor",
+ "team_a=CeleryExecutor,LocalExecutor;team_b=KubernetesExecutor",
+ ],
+ )
+ def test_team_only_configurations_should_fail(self, executor_config):
+ """Test that configurations with only team-based executors fail validation."""
+ with (
+ mock.patch.object(executor_loader.ExecutorLoader, "block_use_of_multi_team"),
+ mock.patch.object(executor_loader.ExecutorLoader, "_validate_teams_exist_in_database"),
+ conf_vars({("core", "executor"): executor_config}),
+ ):
+ with pytest.raises(AirflowConfigException):
Review Comment:
I ended up adding a small match. Let me know if that suffices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce one global executor [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #55816:
URL: https://github.com/apache/airflow/pull/55816#issuecomment-3305243194
CC @vincbeck @ramitkataria
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce one global executor [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #55816:
URL: https://github.com/apache/airflow/pull/55816#issuecomment-3307088899
Some tests failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce at least one global executor is configured [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #55816:
URL: https://github.com/apache/airflow/pull/55816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce one global executor [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #55816:
URL: https://github.com/apache/airflow/pull/55816#discussion_r2359790882
##########
airflow-core/tests/unit/executors/test_executor_loader.py:
##########
@@ -560,3 +549,22 @@ def test_single_global_team_configurations_work(self, executor_config, expected_
with conf_vars({("core", "executor"): executor_config}):
configs = executor_loader.ExecutorLoader._get_team_executor_configs()
assert configs == expected_configs
+
+ @pytest.mark.parametrize(
+ "executor_config",
+ [
+ "team1=CeleryExecutor",
+ "team1=CeleryExecutor;team2=LocalExecutor",
+ "team1=CeleryExecutor;team2=LocalExecutor;team3=KubernetesExecutor",
+ "team_a=CeleryExecutor,LocalExecutor;team_b=KubernetesExecutor",
+ ],
+ )
+ def test_team_only_configurations_should_fail(self, executor_config):
+ """Test that configurations with only team-based executors fail validation."""
+ with (
+ mock.patch.object(executor_loader.ExecutorLoader, "block_use_of_multi_team"),
+ mock.patch.object(executor_loader.ExecutorLoader, "_validate_teams_exist_in_database"),
+ conf_vars({("core", "executor"): executor_config}),
+ ):
+ with pytest.raises(AirflowConfigException):
Review Comment:
Nit: Should we match the message too ?
```suggestion
with pytest.raises(AirflowConfigException, matches=...):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce one global executor [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #55816:
URL: https://github.com/apache/airflow/pull/55816#discussion_r2360730798
##########
airflow-core/tests/unit/executors/test_executor_loader.py:
##########
@@ -560,3 +549,22 @@ def test_single_global_team_configurations_work(self, executor_config, expected_
with conf_vars({("core", "executor"): executor_config}):
configs = executor_loader.ExecutorLoader._get_team_executor_configs()
assert configs == expected_configs
+
+ @pytest.mark.parametrize(
+ "executor_config",
+ [
+ "team1=CeleryExecutor",
+ "team1=CeleryExecutor;team2=LocalExecutor",
+ "team1=CeleryExecutor;team2=LocalExecutor;team3=KubernetesExecutor",
+ "team_a=CeleryExecutor,LocalExecutor;team_b=KubernetesExecutor",
+ ],
+ )
+ def test_team_only_configurations_should_fail(self, executor_config):
+ """Test that configurations with only team-based executors fail validation."""
+ with (
+ mock.patch.object(executor_loader.ExecutorLoader, "block_use_of_multi_team"),
+ mock.patch.object(executor_loader.ExecutorLoader, "_validate_teams_exist_in_database"),
+ conf_vars({("core", "executor"): executor_config}),
+ ):
+ with pytest.raises(AirflowConfigException):
Review Comment:
I actually intentionally didn't add a text matches. Since this is a particular type of exception object I don't think there is much value in matching the text. It mostly is just a nuisance if the message is ever edited. But if you feel strongly I can add one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org