[GitHub] cpcloud commented on a change in pull request #25: Fix OSX RPATHs for Boost

[GitBox <gi...@apache.org>]

cpcloud commented on a change in pull request #25: Fix OSX RPATHs for Boost
URL: https://github.com/apache/arrow-dist/pull/25#discussion_r178132589
 
 

 ##########
 File path: python-macos/config.sh
 ##########
 @@ -65,7 +75,23 @@ function build_wheel {
         install > /dev/null 2>&1
     popd
 
-    export THRIFT_HOME=/usr/local
+    # The boost libraries don't set an explicit install name and we have not
+    # yet found the correct option on `bjam` to set the install name to the
+    # one we desire.
+    #
+    # Set it to @rpath/<binary_name> so that they are search in the same
+    # directory as the library that loaded them.
+    pushd "${arrow_boost_dist}"/lib
+      for dylib in *.dylib; do
+        install_name_tool -id @rpath/${dylib} ${dylib}
+      done
+      install_name_tool -change libarrow_boost_system.dylib @rpath/libarrow_boost_system.dylib libarrow_boost_filesystem.dylib
 
 Review comment:
   What does each of the arguments mean here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services